Bug 1794699: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending #1406

openshift-cherrypick-robot · 2020-01-23T22:27:04Z

This is an automated cherry-pick of #1396

/assign kikisdeliveryservice

The prepend via dhclient doesn't work via ipv6, so switch to a NetworkManager dispatcher that runs after dhclient instead as a workaround. Co-Authored-By: Antoni Segura Puimedon <[email protected]>

Make it clear that we're writing /etc/resolv.conf but also reading the /var/run/NetworkManager/resolv.conf

openshift-ci-robot · 2020-01-23T22:27:05Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2020-01-23T23:56:51Z

cc: @hardys @celebdor @russellb

This will need a BZ created and attached to this PR so it can be merged. Also PTAL just to verify the cherry-pick.

kikisdeliveryservice

I forgot to leave an approval..

hardys · 2020-01-24T09:30:02Z

/retitle Bug 1794661: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending

openshift-ci-robot · 2020-01-24T09:30:06Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1794661, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "---" instead
expected Bugzilla bug 1794661 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1794661: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2020-01-24T09:31:23Z

/bugzilla refresh

openshift-ci-robot · 2020-01-24T09:31:25Z

@hardys: This pull request references Bugzilla bug 1794661, which is invalid:

expected Bugzilla bug 1794661 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2020-01-24T09:32:24Z

cc: @hardys @celebdor @russellb

This will need a BZ created and attached to this PR so it can be merged. Also PTAL just to verify the cherry-pick.

Done, not sure how to satisfy the bot requirement for a bz dependency, any suggestions?

ashcrow · 2020-01-24T09:47:54Z

The BZ referenced here needs to be a dependent of the BZ that was used to PR into master. It looks like one wasn't created 🙁. You could make one, update it to be in the right state, and then link it to this one to satisfy the process (which is there to ensure backports start in master and are cherry picked into previous releases).

celebdor · 2020-01-24T11:05:46Z

I will check as soon as I can

hardys · 2020-01-24T11:13:10Z

@ashcrow Ok thanks, I wasn't aware that bz's for commits to master were mandatory - for other repos e.g installer we've just landed the PR then raised a bz for the stable-branch backport (since master isn't released and doesn't require errata or qe validation?)

I can raise one though and juggle the states, is there any reference to this process I can refer to?

hardys · 2020-01-24T11:21:49Z

Ok I retargetted https://bugzilla.redhat.com/show_bug.cgi?id=1794661 to 4.4 and cloned it to https://bugzilla.redhat.com/show_bug.cgi?id=1794699 for the backport

We need https://bugzilla.redhat.com/show_bug.cgi?id=1794661 to be in the VERIFIED state, but I guess we can have either @celebdor or @russellb dev-verify as they tested this?

hardys · 2020-01-24T11:22:22Z

/retitle Bug 1794699: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending

openshift-ci-robot · 2020-01-24T11:22:25Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1794699, which is invalid:

expected dependent Bugzilla bug 1794661 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1794699: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

russellb · 2020-01-24T14:59:24Z

/bugzilla refresh

openshift-ci-robot · 2020-01-24T14:59:30Z

@russellb: This pull request references Bugzilla bug 1794699, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ashcrow · 2020-01-24T15:01:25Z

I can raise one though and juggle the states, is there any reference to this process I can refer to?

Possibly, but to be honest I'm not sure where. I learned this process the same you you have today (through getting the bugzilla invalid comment and then someone telling me how to get past it).

russellb · 2020-01-24T17:13:29Z

/lgtm

openshift-ci-robot · 2020-01-24T17:14:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, openshift-cherrypick-robot, russellb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hardys · 2020-01-25T10:15:41Z

Hmm anyone know how we get the cherry-pick-approved label?

ashcrow · 2020-01-25T10:32:34Z

@hardys I believe the patch manager must approve.

hardys · 2020-01-28T09:47:21Z

@hardys I believe the patch manager must approve.

Ok, I'm not familiar with that process - any more details?

I also need to propose #1395 to release-4.3 but it conflicts with this backport, I'd hoped we could land this then I can rebase and propose the second backport PR.

eparis · 2020-02-04T19:13:07Z

/bugzilla refresh

openshift-ci-robot · 2020-02-04T19:13:11Z

@eparis: This pull request references Bugzilla bug 1794699, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eparis · 2020-02-04T19:14:39Z

/bugzilla refresh

openshift-ci-robot · 2020-02-04T19:14:42Z

@eparis: This pull request references Bugzilla bug 1794699, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-04T23:12:05Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1794699 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1794699: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Steven Hardy and others added 2 commits January 23, 2020 22:27

baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending

b8dab13

The prepend via dhclient doesn't work via ipv6, so switch to a NetworkManager dispatcher that runs after dhclient instead as a workaround. Co-Authored-By: Antoni Segura Puimedon <[email protected]>

baremetal: Clarify logger output in resolv-prepender

98ef52e

Make it clear that we're writing /etc/resolv.conf but also reading the /var/run/NetworkManager/resolv.conf

openshift-ci-robot assigned kikisdeliveryservice Jan 23, 2020

openshift-cherrypick-robot mentioned this pull request Jan 23, 2020

baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending #1396

Merged

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 23, 2020

openshift-ci-robot requested review from ashcrow and ericavonb January 23, 2020 22:27

kikisdeliveryservice assigned russellb Jan 23, 2020

kikisdeliveryservice requested review from kikisdeliveryservice and removed request for ashcrow and ericavonb January 23, 2020 23:57

kikisdeliveryservice approved these changes Jan 24, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020

openshift-ci-robot changed the title ~~[release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending~~ Bug 1794661: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending Jan 24, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 24, 2020

openshift-ci-robot changed the title ~~Bug 1794661: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending~~ Bug 1794699: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending Jan 24, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 24, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020

hardys mentioned this pull request Jan 28, 2020

Update MCO dispatcher fix openshift-kni/machine-config-operator#3

Merged

eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 4, 2020

openshift-merge-robot merged commit 207cc17 into openshift:release-4.3 Feb 4, 2020

Bug 1794699: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending #1406

Bug 1794699: [release-4.3] baremetal: ipv6, switch to NM dispatcher for DNS VIP prepending #1406

Uh oh!

Conversation

openshift-cherrypick-robot commented Jan 23, 2020

Uh oh!

openshift-ci-robot commented Jan 23, 2020

Uh oh!

kikisdeliveryservice commented Jan 23, 2020

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

hardys commented Jan 24, 2020

Uh oh!

openshift-ci-robot commented Jan 24, 2020

Uh oh!

hardys commented Jan 24, 2020

Uh oh!

openshift-ci-robot commented Jan 24, 2020

Uh oh!

hardys commented Jan 24, 2020

Uh oh!

ashcrow commented Jan 24, 2020

Uh oh!

celebdor commented Jan 24, 2020

Uh oh!

hardys commented Jan 24, 2020

Uh oh!

hardys commented Jan 24, 2020

Uh oh!

hardys commented Jan 24, 2020

Uh oh!

openshift-ci-robot commented Jan 24, 2020

Uh oh!

russellb commented Jan 24, 2020

Uh oh!

openshift-ci-robot commented Jan 24, 2020

Uh oh!

ashcrow commented Jan 24, 2020

Uh oh!

russellb commented Jan 24, 2020

Uh oh!

openshift-ci-robot commented Jan 24, 2020

Uh oh!

hardys commented Jan 25, 2020

Uh oh!

ashcrow commented Jan 25, 2020

Uh oh!

hardys commented Jan 28, 2020

Uh oh!

eparis commented Feb 4, 2020

Uh oh!

openshift-ci-robot commented Feb 4, 2020

Uh oh!

eparis commented Feb 4, 2020

Uh oh!

openshift-ci-robot commented Feb 4, 2020

Uh oh!

openshift-ci-robot commented Feb 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants