Bug 1790823: [IPI][BAREMETAL] Verify that mdns-publisher starts after hostname is set #1388
Conversation
|
@yboaron: This pull request references Bugzilla bug 1790823, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
cybertron
left a comment
cybertron
left a comment
There was a problem hiding this comment.
Testing this locally. One comment inline.
There was a problem hiding this comment.
Maybe want to put quotes around $(hostname)? I don't know if there would be anything in a hostname that would mess up the check, but this being bash I generally err on the side of caution.
This change verifies that mdns-publisher pod advertises node's name only after hostname being set.
cybertron
left a comment
cybertron
left a comment
There was a problem hiding this comment.
/lgtm
Passed my local test and my previous comment was addressed.
|
/retest |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@yboaron: This pull request references Bugzilla bug 1790823, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/retest |
1 similar comment
|
/retest |
|
@yboaron: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, runcom, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@yboaron: All pull requests linked via external trackers have merged. Bugzilla bug 1790823 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change verifies that mdns-publisher pod advertises node's name only after hostname being set. This ports the BM change from openshift#1388 to OpenStack platform.
This change verifies that mdns-publisher pod advertises node's name only after hostname being set. This ports the BM change from openshift#1388 to OpenStack platform.
7 participants
This change verifies that mdns-publisher pod advertises node's
name only after hostname being set.
- What I did
- How to verify it
- Description for the changelog