Skip to content

bump openshift api and update FeatureGates #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcpowermac wants to merge 2 commits into from
Closed

bump openshift api and update FeatureGates #1377

jcpowermac wants to merge 2 commits into from

Conversation

@jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Jan 16, 2020

To get this to work I had to run:

go mod edit -replace github.com/openshift/api=github.com/openshift/api@0e2ff1e
make go-deps

Dependancy for PR: #1373

@jcpowermac
bump openshift api
3a953f5 
```
go mod edit -replace github.com/openshift/api=github.com/openshift/api@0e2ff1e
make go-deps
```
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 16, 2020
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jan 16, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jan 16, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020
@kikisdeliveryservice kikisdeliveryservice changed the title bump openshift api bump openshift api and update FeatureGates Jan 17, 2020
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jan 20, 2020

/assign @yuqi-zhang

@sdodson sdodson mentioned this pull request Jan 20, 2020
Merged
yuqi-zhang added a commit to yuqi-zhang/machine-config-operator that referenced this pull request Jan 21, 2020
@yuqi-zhang
Dependencies: update to kubernetes-1.17.1
ca192d9 
Openshift 4.4 will be targeting 1.17. Since we will need api
updates for openshift#1377,
might as well update all kube items while we're at it.

Note that we used to use openshift/kubernetes/* repos, but they
haven't been updated for awhile. Targeting upstream directly instead.

Signed-off-by: Yu Qi Zhang <jerzhang@redhat.com>
@yuqi-zhang yuqi-zhang mentioned this pull request Jan 21, 2020
Merged
@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Jan 21, 2020

/retest

I'm thinking of bumping everything together in #1393 but I'm not sure if that's entirely correct. If that doesn't work we can merge this first.

The AWS error seems infra related so lets try again

@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Jan 21, 2020

/retest

There are some weird test failures I'm working out for the other PR, so until then let's see if we can get this past CI, and we can merge this while I work on fixing kubelet tests.

yuqi-zhang
yuqi-zhang approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jan 22, 2020

@ericavonb or @kikisdeliveryservice can you PTAL.

@runcom
Copy link
Member

runcom commented Jan 22, 2020

/retest

@runcom
Copy link
Member

runcom commented Jan 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, runcom, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@runcom
Copy link
Member

runcom commented Jan 23, 2020

/hold

we might be able to land #1393 today which supersedes this :)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2020

@jcpowermac: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade 4224ffc link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jan 23, 2020

/close
#1393
hopefully will merge shortly :)

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2020

@jcpowermac: Closed this PR.

Details

In response to this:

/close
#1393
hopefully will merge shortly :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs pushed a commit to vrutkovs/machine-config-operator that referenced this pull request Mar 1, 2020
@yuqi-zhang
Dependencies: update to kubernetes-1.17.1
c9a8c75 
Openshift 4.4 will be targeting 1.17. Since we will need api
updates for openshift#1377,
might as well update all kube items while we're at it.

Note that we used to use openshift/kubernetes/* repos, but they
haven't been updated for awhile. Targeting upstream directly instead.

Signed-off-by: Yu Qi Zhang <jerzhang@redhat.com>
vrutkovs pushed a commit to vrutkovs/machine-config-operator that referenced this pull request Mar 1, 2020
@yuqi-zhang
Dependencies: update to kubernetes-1.17.1
8c4b566 
Openshift 4.4 will be targeting 1.17. Since we will need api
updates for openshift#1377,
might as well update all kube items while we're at it.

Note that we used to use openshift/kubernetes/* repos, but they
haven't been updated for awhile. Targeting upstream directly instead.

Signed-off-by: Yu Qi Zhang <jerzhang@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@ericavonb ericavonb Awaiting requested review from ericavonb

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@runcom runcom

@yuqi-zhang yuqi-zhang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jcpowermac @yuqi-zhang @runcom @openshift-ci-robot @openshift-bot