Skip to content

[fcos] templates/container-storage: Add a "this is generated" note #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jan 16, 2020
Merged

[fcos] templates/container-storage: Add a "this is generated" note #1372

openshift-merge-robot merged 2 commits into from
Jan 16, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 15, 2020

This is an automated cherry-pick of #1320

/assign vrutkovs

@cgwalters
templates: Move container-storage.yaml into common/
7e95edb 
It's identical between master/worker, so move it into the
common pool.

Just a cleanup while looking at
openshift#1319
@cgwalters
templates/container-storage: Add a "this is generated" note
4e74807 
This is a best practice, and particularly in this case
when we're intending to modify a config file, it can't be identical
to the shipped version.

This avoids having libostree replace it with a newer version.

Closes: openshift#1319
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 15, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1781708, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected Bugzilla bug 1781708 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[fcos] Bug 1781708: templates/container-storage: Add a "this is generated" note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2020
@vrutkovs
Copy link
Contributor

vrutkovs commented Jan 15, 2020

/retitle [fcos] templates/container-storage: Add a "this is generated" note

@openshift-ci-robot openshift-ci-robot changed the title [fcos] Bug 1781708: templates/container-storage: Add a "this is generated" note [fcos] templates/container-storage: Add a "this is generated" note Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2020

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[fcos] templates/container-storage: Add a "this is generated" note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 15, 2020
@LorbusChris
Copy link
Contributor

LorbusChris commented Jan 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@vrutkovs
Copy link
Contributor

vrutkovs commented Jan 16, 2020

/override ci/prow/e2e-aws

Known issues

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2020

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-aws

Details

In response to this:

/override ci/prow/e2e-aws

Known issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a7feccb into openshift:fcos Jan 16, 2020
@vrutkovs vrutkovs mentioned this pull request Jan 16, 2020
Closed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2020

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 4e74807 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrmac mtrmac Awaiting requested review from mtrmac

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@vrutkovs vrutkovs

@LorbusChris LorbusChris

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @vrutkovs @LorbusChris @openshift-bot @openshift-merge-robot @cgwalters