-
Notifications
You must be signed in to change notification settings - Fork 462
*: enable cluster-etcd-operator #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is necessary to prevent races
|
/hold We don't want this to merge until we are ready with installer PR. |
|
/lgtm apart from the hold, this lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alaypatel07, hexfusion The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Required installer pr: openshift/installer#2608 |
|
/skip |
|
@hexfusion: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
We will try this again in 4.4 |
Currently, we use the presence/existence of the clusterEtcdOperatorImageKey flag value and the value of the clusterEtcdOperatorImage [1] [2] as a condition for using the old style SRV bootstrap or enable cluster-etcd-operator to scale etcd. This PR would enable 4.3 scaling for MCO.
https://github.com/openshift/machine-config-operator/blob/release-4.3/templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml#L22
https://github.com/openshift/machine-config-operator/compare/master...hexfusion:enable_ceo?expand=1#diff-cbbafda65814e4ab5960f98e6b8c109fR14