[fcos] templates: place /etc/pivot/kernel-args on masters/workers

[vrutkovs]

This would disable cgroupsv2 and Spectre mitigations. These files are served by MCD to ensure correct initial hash on masters is being calculated

[vrutkovs]

/hold

Testing it locally

[vrutkovs]

/hold cancel

Works fine here

[cgwalters]

This should use the encapsulated MachineConfig with kernelArguments.

[vrutkovs]

This should use the encapsulated MachineConfig with kernelArguments.

I was trying to add a new MC via installer, but that made node annotations to have a wrong rendered machine config hash. Eventually all this would be cleaned up

[ericavonb]

I was trying to add a new MC via installer, but that made node annotations to have a wrong rendered machine config hash.

That shouldn't happen. How were you adding the new machineconfig?

[vrutkovs]

/lgtm
/override ci/prow/e2e-aws

[openshift-ci-robot]

@vrutkovs: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-aws

Details

In response to this:

/lgtm
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vrutkovs]

That shouldn't happen. How were you adding the new machineconfig?

Via the installer - openshift/installer@1f837e7

https://kubernetes.slack.com/archives/C6BRQSH2S/p1572621344249600:

riiiiight, so during bootstrap node annotations has a hash of expected machineconfig and later on MCD won't reboot this node as its expected to have the config already

but the trick is that installer creates a new MC with fcos tweaks (in RHCOS it would disable hyperthreading) - and thus rendered machineconfig has a different hash

and MCP can't proceed cause initial rendered config has never in fact existed

[vrutkovs]

/lgtm

[openshift-ci-robot]

@vrutkovs: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[LorbusChris]

ok, let's do this for now. We can do any clean ups/polishing of this a bit further down the road.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [LorbusChris,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrutkovs]

I agree this is certainly a bad hack and would be reverted, but without e2e its hard to come up with a better fix

[openshift-ci-robot]

@vrutkovs: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	ea203ec	link	/test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vrutkovs]

/override ci/prow/e2e-aws

[openshift-ci-robot]

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-aws

Details

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.