Skip to content

[Baremetal] - update haproxy statistics url #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 6, 2019
Merged

[Baremetal] - update haproxy statistics url #1219

openshift-merge-robot merged 1 commit into from
Nov 6, 2019

Conversation

@yboaron
Copy link
Contributor

@yboaron yboaron commented Oct 29, 2019

Update statistics url in Haproxy config to support both
IPv4 and IPv6 (single stack).

- What I did

- How to verify it

- Description for the changelog

Baremetal - update haproxy statistics url
1b24fdb 
Update statistics url in Haproxy config to support both
IPv4 and IPv6 (single stack).
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2019
@yboaron
Copy link
Contributor Author

yboaron commented Oct 29, 2019

/cc @celebdor

@yboaron
Copy link
Contributor Author

yboaron commented Oct 29, 2019

/cc @bcrochet

@yboaron
Copy link
Contributor Author

yboaron commented Oct 29, 2019

/cc @cybertron

@bcrochet
Copy link
Member

bcrochet commented Oct 29, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019
@celebdor
Copy link
Contributor

celebdor commented Oct 30, 2019

/retest

@celebdor
Copy link
Contributor

celebdor commented Oct 30, 2019

/lgtm

@yboaron
Copy link
Contributor Author

yboaron commented Oct 30, 2019

/retest

1 similar comment
@yboaron
Copy link
Contributor Author

yboaron commented Nov 3, 2019

/retest

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Nov 6, 2019

/skip

kikisdeliveryservice
kikisdeliveryservice approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, celebdor, cybertron, kikisdeliveryservice, yboaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 6, 2019 •
edited
Loading

@yboaron: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 1b24fdb link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e0bbf20 into openshift:master Nov 6, 2019
mandre added a commit to mandre/machine-config-operator that referenced this pull request Feb 18, 2020
@mandre
OpenStack - update haproxy statistics url
f0a38d8 
Update statistics url in Haproxy config to support both
IPv4 and IPv6 (single stack).

This ports BM fix from
openshift#1219 to
OpenStack platform.
@mandre mandre mentioned this pull request Feb 18, 2020
Merged
vrutkovs pushed a commit to vrutkovs/machine-config-operator that referenced this pull request Mar 1, 2020
@mandre
OpenStack - update haproxy statistics url
c314cc3 
Update statistics url in Haproxy config to support both
IPv4 and IPv6 (single stack).

This ports BM fix from
openshift#1219 to
OpenStack platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@ericavonb ericavonb Awaiting requested review from ericavonb

@celebdor celebdor Awaiting requested review from celebdor

@bcrochet bcrochet Awaiting requested review from bcrochet

2 more reviewers

@cybertron cybertron cybertron approved these changes

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bcrochet bcrochet

@celebdor celebdor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@yboaron @bcrochet @celebdor @kikisdeliveryservice @openshift-ci-robot @openshift-bot @cybertron @openshift-merge-robot