Bug 1763695: [release-4.2] pkg/daemon: drain before applying changes

[runcom]

backport of #1200

Signed-off-by: Antonio Murdaca [email protected]

[openshift-ci-robot]

@runcom: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

pkg/daemon: drain before applying changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgwalters]

/approve
I am not sure why we didn't do this from the very start. It seems a lot safer.
That said, I do think a longer term fix is #1190 - but that's harder (and actually would only apply to RHCOS, but we'd still want to drain classic RHEL first).

[cgwalters]

Hm, is there no master equivalent of this PR?

[cgwalters]

Also worth a least a summary of why we need this in the commit message - something like:

Since the MCO owns writing kubelet static pod configurations, we need to drain before attempting to change them so that e.g. the etcd-quorum-guard's PDB has a chance to operate. This would have also mitigated a bug in 4.1 to 4.2 upgrades - see #1177

[openshift-ci-robot]

@runcom: This pull request references Bugzilla bug 1762536, which is invalid:

• expected the bug to target the "4.2.z" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1762536: pkg/daemon: drain before applying changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@runcom: This pull request references Bugzilla bug 1762536, which is invalid:

• expected the bug to target the "4.2.z" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1762536: pkg/daemon: drain before applying changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@runcom: This pull request references Bugzilla bug 1763695, which is invalid:

• expected dependent Bugzilla bug 1762536 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1763695: [release-4.2] pkg/daemon: drain before applying changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[runcom]

/cherrypick release-4.1

4.1 BZ here: https://bugzilla.redhat.com/show_bug.cgi?id=1763696

[openshift-cherrypick-robot]

@runcom: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.1

4.1 BZ here: https://bugzilla.redhat.com/show_bug.cgi?id=1763696

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@runcom: This pull request references Bugzilla bug 1763695, which is invalid:

• expected dependent Bugzilla bug 1762536 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1763695: [release-4.2] pkg/daemon: drain before applying changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgwalters]

/lgtm

[cgwalters]

Does this one need to have been explicitly created as a cherry-pick of the master PR? Maybe it doesn't matter and we just need an architect to do the label dance.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cgwalters,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[runcom]

Patch manager will add the label to pick this up, we're waiting on this to let it soak a bit in master

[eparis]

This will not be able to merge until BZ 1762536 has been VERIFIED by QE. And after that someone runs /bugzilla refresh

[kikisdeliveryservice]

/bugzilla refresh

[openshift-ci-robot]

@kikisdeliveryservice: This pull request references Bugzilla bug 1763695, which is invalid:

• expected dependent Bugzilla bug 1762536 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

/bugzilla refresh

[openshift-ci-robot]

@kikisdeliveryservice: This pull request references Bugzilla bug 1763695, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@runcom: All pull requests linked via external trackers have merged. Bugzilla bug 1763695 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1763695: [release-4.2] pkg/daemon: drain before applying changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@runcom: #1194 failed to apply on top of branch "release-4.1":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/daemon/daemon.go
M	pkg/daemon/update.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/daemon/update.go
CONFLICT (content): Merge conflict in pkg/daemon/update.go
Auto-merging pkg/daemon/daemon.go
CONFLICT (content): Merge conflict in pkg/daemon/daemon.go
Patch failed at 0001 pkg/daemon: drain before applying changes

Details

In response to this:

/cherrypick release-4.1

4.1 BZ here: https://bugzilla.redhat.com/show_bug.cgi?id=1763696

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

@runcom your cherry pick to 4.1 failed..