Bug 1762868: revert #1177 and fix common templates in MCs #1189
Conversation
|
@runcom: This pull request references Bugzilla bug 1762868, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
runcom
force-pushed
the
cc-versioninig
branch
from
e122871 to
2f63c9d
Compare
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@runcom: This pull request references Bugzilla bug 1762868, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.2 |
|
@runcom: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
runcom
force-pushed
the
cc-versioninig
branch
2 times, most recently
from
9b71d01 to
b6bd360
Compare
|
/approve |
|
Sorry about the common template regression; patch on that looks OK. I feel like this code could use a broader cleanup (and we could use some asserts that we're not generating duplicate files since that's a hard error in Ignition spec 3) but let's do the simple fix first! |
|
And to help me understand - in order to fix the bug, we need to backport this all the way to 4.1, right? |
I think 4.1 can live w/o the controllerconfig version fix (as it will compare against the empty string and still be correct) As for the other common template fix, yeah, need proper backport till 4.1 but not as urgent maybe |
|
/retest |
…didn't change" This reverts commit 6e091e8.
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
cc-versioninig
branch
from
b6bd360 to
fd51c74
Compare
|
@runcom: This pull request references Bugzilla bug 1762868, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
runcom
changed the title
|
@runcom: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4.2 BZ is already here https://bugzilla.redhat.com/show_bug.cgi?id=1763205 for the cherry-pick |
|
/hold cancel Good to go |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, mrunalp, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@runcom: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-aws |
|
@runcom: All pull requests linked via external trackers have merged. Bugzilla bug 1762868 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@runcom: new pull request created: #1202 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
What #1177 had inadvertently regressed is that our MCs aren't rolled back anymore. This was sort of fine till the BZ came in, which exposed another bug we had. Basically, the code was adding duplicate and triplicates of common files all over. If you pair that with #1177, you'll get the bug in the title.