Adds MachineConfig Operator #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
crawford
reviewed
Aug 7, 2018
Dockerfile.machine-config-controller
Outdated
Contributor
There was a problem hiding this comment.
You can use WORKDIR instead of changing directory.
abhinavdahiya
force-pushed
the
operator
branch
4 times, most recently
from
5741373 to
59713cd
Compare
yifan-gu
reviewed
Aug 9, 2018
pkg/operator/sync.go
Outdated
There was a problem hiding this comment.
nit: can you use a for loop for these?
yifan-gu
reviewed
Aug 9, 2018
pkg/operator/sync.go
Outdated
yifan-gu
reviewed
Aug 9, 2018
pkg/operator/sync.go
Outdated
There was a problem hiding this comment.
same here, we can create a map from the asset name to their render and read functions, and potentially wait for the resources. Should be pretty generic to reduce the code redundancy .
Contributor
Author
There was a problem hiding this comment.
read* and apply* expect specific types.
Will end up doing bunch of type assertions.
yifan-gu
reviewed
Aug 9, 2018
pkg/operator/sync.go
Outdated
|
@abhinavdahiya LGTM overall, but seems a lot of the reconcile code can be compressed |
abhinavdahiya
force-pushed
the
operator
branch
2 times, most recently
from
2009ce6 to
d7d0cc7
Compare
openshift-bot
added
the
needs-rebase
manifests/ -> are all the object that operator continuously manages. install/ -> are all the objects that need to be installed but not maned by the operator.
abhinavdahiya
force-pushed
the
operator
branch
from
d7d0cc7 to
c57ad74
Compare
openshift-bot
removed
the
needs-rebase
Contributor
Author
|
@yifan-gu PTAL |
alaypatel07
pushed a commit
to alaypatel07/machine-config-operator
that referenced
this pull request
Oct 30, 2019
*: add render keys to generate appropriate commands for etcd certs
osherdp
pushed a commit
to osherdp/machine-config-operator
that referenced
this pull request
Apr 13, 2021
deploy: add ordering to manifests that end up in updatepayload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/operator/assets/bindata.go)pkg/operator/assets/bindata.go)Follow up: