Skip to content

Conversation

@yboaron
Copy link
Contributor

@yboaron yboaron commented Aug 20, 2019

The 'curl' commands on the keepalived static pod cause a huge amount of memory dentries.
The underlying bug is https://bugzilla.redhat.com/show_bug.cgi?id=1571183.
This commit work-around this problem.
For more details see:
#705
openshift/openshift-ansible#11829

- What I did

- How to verify it

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 20, 2019
@runcom runcom changed the title [Baremetal and Openstack] avoid excessive dentries due to keepalived static pod health check Bug 1571183: [Baremetal and Openstack] avoid excessive dentries due to keepalived static pod health check Aug 20, 2019
@openshift-ci-robot
Copy link
Contributor

@yboaron: This pull request references Bugzilla bug 1571183, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.2.0" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is CLOSED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1571183: [Baremetal and Openstack] avoid excessive dentries due to keepalived static pod health check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 20, 2019
@runcom
Copy link
Member

runcom commented Aug 20, 2019

oh ok, this is not fixing 1571183, we need a valid bz for 4.2 to land this, can you create one @yboaron and link it here?

@runcom runcom changed the title Bug 1571183: [Baremetal and Openstack] avoid excessive dentries due to keepalived static pod health check [Baremetal and Openstack] avoid excessive dentries due to keepalived static pod health check Aug 20, 2019
@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 20, 2019
@openshift-ci-robot
Copy link
Contributor

@yboaron: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[Baremetal and Openstack] avoid excessive dentries due to keepalived static pod health check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yboaron yboaron changed the title [Baremetal and Openstack] avoid excessive dentries due to keepalived static pod health check Bug: 1743768: avoid excessive dentries due to keepalived static pod health check Aug 20, 2019
@yboaron yboaron changed the title Bug: 1743768: avoid excessive dentries due to keepalived static pod health check Bug 1743768: avoid excessive dentries due to keepalived static pod health check Aug 20, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 20, 2019
@openshift-ci-robot
Copy link
Contributor

@yboaron: This pull request references Bugzilla bug 1743768, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1743768: avoid excessive dentries due to keepalived static pod health check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yboaron
Copy link
Contributor Author

yboaron commented Aug 20, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@yboaron: This pull request references Bugzilla bug 1743768, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom
Copy link
Member

runcom commented Aug 20, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@runcom: This pull request references Bugzilla bug 1743768, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 20, 2019
@runcom
Copy link
Member

runcom commented Aug 20, 2019

@yboaron you need to run make update also
/approve

would love someone from Baremetal/OpenStack to lgtm this also after verification

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, yboaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
@yboaron
Copy link
Contributor Author

yboaron commented Aug 20, 2019

/cc @celebdor @bcrochet

@bcrochet
Copy link
Member

@yboaron You need to re-generate the bindata. 'make update'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be simpler to

    env:
    - name: NSS_SDB_USE_CACHE
      value: "no"

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Please try that, @yboaron

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgwalters , Yep, looks like a nicer way to set this variable. I'll verify it on my env and will update the PR. 10x

…static pod health scripts

curl commands on the keepalived static pod cause a huge amount of memory dentries.
The underlying bug is https://bugzilla.redhat.com/show_bug.cgi?id=1571183.

For more details see:
#705
openshift/openshift-ansible#11829
@openshift-ci-robot openshift-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 25, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 25, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 25, 2019

@yboaron: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/verify 23843cc link /test verify
ci/prow/e2e-aws 23843cc link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom
Copy link
Member

runcom commented Aug 27, 2019

can we just close this PR as it's effectively a duplicate of #1083 now?

@celebdor
Copy link
Contributor

celebdor commented Aug 27, 2019 via email

@runcom runcom closed this Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants