-
Notifications
You must be signed in to change notification settings - Fork 463
Bug 1743768: avoid excessive dentries due to keepalived static pod health check #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@yboaron: This pull request references Bugzilla bug 1571183, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
oh ok, this is not fixing 1571183, we need a valid bz for 4.2 to land this, can you create one @yboaron and link it here? |
|
@yboaron: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@yboaron: This pull request references Bugzilla bug 1743768, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@yboaron: This pull request references Bugzilla bug 1743768, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@runcom: This pull request references Bugzilla bug 1743768, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@yboaron you need to run would love someone from Baremetal/OpenStack to lgtm this also after verification |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yboaron You need to re-generate the bindata. 'make update' |
manifests/baremetal/keepalived.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be simpler to
env:
- name: NSS_SDB_USE_CACHE
value: "no"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Please try that, @yboaron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgwalters , Yep, looks like a nicer way to set this variable. I'll verify it on my env and will update the PR. 10x
…static pod health scripts curl commands on the keepalived static pod cause a huge amount of memory dentries. The underlying bug is https://bugzilla.redhat.com/show_bug.cgi?id=1571183. For more details see: #705 openshift/openshift-ansible#11829
|
@yboaron: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
can we just close this PR as it's effectively a duplicate of #1083 now? |
|
Yes. We can indeed.
…On Tue, Aug 27, 2019, 17:51 Antonio Murdaca ***@***.***> wrote:
can we just close this PR as it's effectively a duplicate of #1083
<#1083> now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1070?email_source=notifications&email_token=AAEXHH4CYORV66WK6JYKZU3QGVEOLA5CNFSM4INYIY42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IGY2Y#issuecomment-525364331>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEXHHYIJ7RXUTRTUJDML7LQGVEOLANCNFSM4INYIY4Q>
.
|
The 'curl' commands on the keepalived static pod cause a huge amount of memory dentries.
The underlying bug is https://bugzilla.redhat.com/show_bug.cgi?id=1571183.
This commit work-around this problem.
For more details see:
#705
openshift/openshift-ansible#11829
- What I did
- How to verify it
- Description for the changelog