openstack: keepalived to pass cluster-config.yml to runtimecfg #1050
Conversation
This pulls in fix openshift#1043 for openstack. A recent installer change started using a loopback address in kubeconfig as the default on the bootstrap node. baremetal-runtimecfg will begin using cluster-config.yml if it exists first, in order to get the domain and name of the cluster. This patch adds a flag for this to the keepalived bootstrap pod in order to utilize it. This should only affect the bootstrap pods.
openshift-ci-robot
added
the
size/S
|
/assign |
|
/label platform/openstack |
|
/lgtm |
|
/test e2e-openstack |
|
/assign @kikisdeliveryservice Please take a look, this mirrors a change already merged for baremetal and it fixes a deployment & CI issue we're seeing with OpenStack. |
|
Hi @kikisdeliveryservice, this PR unblocks openshift/installer#1959, meaning we likely won't need #1040 and can simply revert 759702e as was the original plan. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, runcom, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
6 participants
This pulls in fix
#1043 for
openstack.
A recent installer change started using a loopback address in
kubeconfig as the default on the bootstrap node. baremetal-runtimecfg
will begin using cluster-config.yml if it exists first, in order to get
the domain and name of the cluster.
This patch adds a flag for this to the keepalived bootstrap pod in
order to utilize it. This should only affect the bootstrap pods.
- What I did
- How to verify it
- Description for the changelog