Skip to content

NO-JIRA: Bump machine-api-operator to pull in authoritativeAPI fix#120

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
damdo:bump-mao-authoritativeAPI-fix
Jul 8, 2025
Merged

NO-JIRA: Bump machine-api-operator to pull in authoritativeAPI fix#120
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
damdo:bump-mao-authoritativeAPI-fix

Conversation

@damdo
Copy link
Member

@damdo damdo commented Jul 4, 2025

@openshift-ci openshift-ci bot requested review from hamzy and jaypoulz July 4, 2025 07:23
@damdo
Copy link
Member Author

damdo commented Jul 4, 2025

@Karthik-K-N do we normally these PRs this manually before merging?

@Karthik-K-N
Copy link
Member

@Karthik-K-N do we normally these PRs this manually before merging?

I hope you mean testing them before merging and yes we can do that.

@aman4433 would you be able to help us?

@damdo
Copy link
Member Author

damdo commented Jul 4, 2025

@Karthik-K-N yes that's what I meant :) thanks both!

@RadekManak
Copy link
Contributor

/lgtm
/approve
/hold
@aman4433 unhold when you finish testing.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@aman4433
Copy link
Contributor

aman4433 commented Jul 8, 2025

Tested the controller locally by scaling the Machineset ipi420syd5-58wx9-worker from 3 to 4. Machine ipi420syd5-58wx9-worker-qptbm was created, and the corresponding node became Ready. All controllers in openshift-machine-api are running. Working as expected.

/lgtm
/unhold

amanshrivastava@Amans-MacBook-Pro machine-api-provider-powervs % oc get pods -n openshift-machine-api
NAME                                                  READY   STATUS    RESTARTS        AGE
cluster-autoscaler-operator-9fddc97db-k49n5           2/2     Running   1 (6h21m ago)   6h35m
cluster-baremetal-operator-6f5d7f6456-nn672           2/2     Running   1 (6h21m ago)   6h33m
control-plane-machine-set-operator-75759dc878-zd2br   1/1     Running   1 (6h21m ago)   6h35m
machine-api-controllers-b98b4cf9-rpxs7                7/7     Running   4 (6h21m ago)   6h25m

image

image

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2025

@aman4433: changing LGTM is restricted to collaborators

Details

In response to this:

Tested the controller locally by scaling the Machineset ipi420syd5-58wx9-worker from 3 to 4. Machine ipi420syd5-58wx9-worker-qptbm was created, and the corresponding node became Ready. All controllers in openshift-machine-api are running. Working as expected.

/lgtm
/unhold

amanshrivastava@Amans-MacBook-Pro machine-api-provider-powervs % oc get pods -n openshift-machine-api
NAME                                                  READY   STATUS    RESTARTS        AGE
cluster-autoscaler-operator-9fddc97db-k49n5           2/2     Running   1 (6h21m ago)   6h35m
cluster-baremetal-operator-6f5d7f6456-nn672           2/2     Running   1 (6h21m ago)   6h33m
control-plane-machine-set-operator-75759dc878-zd2br   1/1     Running   1 (6h21m ago)   6h35m
machine-api-controllers-b98b4cf9-rpxs7                7/7     Running   4 (6h21m ago)   6h25m

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aman4433 for validating it.

/lgtm

/unhold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aman4433, damdo, Karthik-K-N, RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025
@Karthik-K-N
Copy link
Member

/retest

@damdo
Copy link
Member Author

damdo commented Jul 8, 2025

/retitle NO-JIRA: Bump machine-api-operator to pull in authoritativeAPI fix

@damdo
Copy link
Member Author

damdo commented Jul 8, 2025

Thanks all! @Karthik-K-N @aman4433

@openshift-ci openshift-ci bot changed the title Bump machine-api-operator to pull in authoritativeAPI fix NO-JIRA: Bump machine-api-operator to pull in authoritativeAPI fix Jul 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2025
@openshift-ci-robot
Copy link

@damdo: This pull request explicitly references no jira issue.

Details

In response to this:

Ref: openshift/machine-api-operator#1386

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f54657d into openshift:main Jul 8, 2025
9 of 10 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-powervs-machine-controllers
This PR has been included in build ose-powervs-machine-controllers-container-v4.20.0-202507081544.p0.gf54657d.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments