Skip to content

Conversation

@kwoodson
Copy link

@kwoodson kwoodson commented Nov 11, 2021

What this PR does / why we need it:
This PR aligns with the work to move machine api libraries to openshift/api. This work updates the machine-api-operator dependency, removes AWS and Azure dependencies, and simplifies the go.mod.

Special notes for your reviewer:
0 code changes introduced. Migrating libraries to openshift/api in order to clean up go.mod dependencies and align with the latest branches.

Release note:

Migrating machine api libraries to openshift/api

Follow up to openshift/cluster-api-provider-openstack#206

@openshift-ci openshift-ci bot requested a review from iamemilio November 11, 2021 18:03
@mdbooth
Copy link
Contributor

mdbooth commented Nov 11, 2021

I can't remember what state the e2e tests are in, but basically as long as this compiles it

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@iamemilio
Copy link
Contributor

I can't remember what state the e2e tests are in, but basically as long as this compiles it

/lgtm

They do not work yet

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

@kwoodson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 62278ae link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwoodson, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0890432 into master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants