Skip to content

Support categories and project fields of NutanixMachineProviderConfig #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Feb 22, 2023
Merged

Support categories and project fields of NutanixMachineProviderConfig #38

openshift-merge-robot merged 2 commits into from
Feb 22, 2023

Conversation

@yanhua121
Copy link
Contributor

@yanhua121 yanhua121 commented Feb 3, 2023 •
edited
Loading

@yanhua121 yanhua121 marked this pull request as draft February 3, 2023 17:58
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2023
@elmiko elmiko mentioned this pull request Feb 6, 2023
Merged
@huali9 huali9 mentioned this pull request Feb 7, 2023
Closed
@huali9
Copy link

huali9 commented Feb 10, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 10, 2023
@yanhua121 yanhua121 marked this pull request as ready for review February 10, 2023 15:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2023
@openshift-ci openshift-ci bot requested review from JoelSpeed and removed request for Fedosin February 10, 2023 15:39
JoelSpeed
JoelSpeed reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to see some unit testing of these new features where possible

@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 14, 2023

Would be nice to see some unit testing of these new features where possible

Added unit testing of some invalid configuration of these new fields in the acutator_test.go.

@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 14, 2023

/test e2e-nutanix

@yanhua121 yanhua121 force-pushed the categories-project branch 2 times, most recently from 50b04c3 to 92d914a Compare February 15, 2023 16:54
JoelSpeed
JoelSpeed reviewed Feb 16, 2023
View reviewed changes
@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 17, 2023

/test e2e-nutanix

1 similar comment
@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 17, 2023

/test e2e-nutanix

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Feb 21, 2023

Just that one comment, otherwise I think this is ok, I'd like to get a second pair of eyes on it though

elmiko
elmiko reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, i think Joel raises a good question though.

JoelSpeed
JoelSpeed reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validated providerspec idea makes sense, good solution 👍

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Feb 22, 2023

/approve
/assign @elmiko

@elmiko
Copy link
Contributor

elmiko commented Feb 22, 2023

nice updates @yanhua121 , thanks!
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 22, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@elmiko
Copy link
Contributor

elmiko commented Feb 22, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

@yanhua121: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-nutanix 68c994b link false /test e2e-nutanix
ci/prow/e2e-nutanix-operator 68c994b link false /test e2e-nutanix-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e0f567f into openshift:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@odvarkadaniel odvarkadaniel Awaiting requested review from odvarkadaniel

+1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yanhua121 @huali9 @JoelSpeed @elmiko @openshift-merge-robot