Skip to content

Comments

[OCPCLOUD-1371] Refactor provider status to use metav1.Condition#8

Merged
openshift-merge-robot merged 2 commits intoopenshift:mainfrom
RadekManak:condition_refactor
Mar 29, 2022
Merged

[OCPCLOUD-1371] Refactor provider status to use metav1.Condition#8
openshift-merge-robot merged 2 commits intoopenshift:mainfrom
RadekManak:condition_refactor

Conversation

@RadekManak
Copy link
Contributor

@RadekManak RadekManak commented Mar 29, 2022

This PR bumps openshift/api to the latest version with condition changes and refactors this provider to use metav1.Condition.

API change PR (merged): openshift/api#1135

JoelSpeed
JoelSpeed reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
alexander-demicev
alexander-demicev approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@RadekManak
Copy link
Contributor Author

RadekManak commented Mar 29, 2022

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 423ba26 into openshift:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

+1 more reviewer

@alexander-demicev alexander-demicev alexander-demicev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexander-demicev alexander-demicev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RadekManak @openshift-bot @JoelSpeed @alexander-demicev @openshift-merge-robot