Skip to content

OCPCLOUD-2986,OCPCLOUD-2985,OCPBUGS-56849: Bump machine-api-operator to pull in authoritativeAPI fix#122

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
damdo:bump-mao-authoritativeAPI-fix
Jul 7, 2025
Merged

OCPCLOUD-2986,OCPCLOUD-2985,OCPBUGS-56849: Bump machine-api-operator to pull in authoritativeAPI fix#122
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
damdo:bump-mao-authoritativeAPI-fix

Conversation

@damdo
Copy link
Member

@damdo damdo commented Jul 4, 2025

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 4, 2025 •
edited by openshift-ci bot
Loading

@damdo: This pull request references OCPCLOUD-2986 which is a valid jira issue.

This pull request references OCPCLOUD-2985 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-56849, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Ref: openshift/machine-api-operator#1386

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2025

@damdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn dc4902c link false /test okd-scos-e2e-aws-ovn
ci/prow/regression-clusterinfra-gcp-ipi-mapi dc4902c link false /test regression-clusterinfra-gcp-ipi-mapi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member Author

damdo commented Jul 4, 2025

/hold

for testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025
@RadekManak
Copy link
Contributor

RadekManak commented Jul 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@RadekManak
Copy link
Contributor

RadekManak commented Jul 7, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@sunzhaohua2
Copy link

sunzhaohua2 commented Jul 7, 2025

/label qe-approved

Tested with pr 122 on gcp

  • machineset's .status.authoritativeAPI are defaulting and setting it to .spec.authoritativeAPI.
  • There are .status.authoritativeAPI for machines as well.
  • If machineset spec.authoritativeAPI is ClusterAPI, no mapi machine is created. mapi machineset paused True.
  • Created 2 standalone machines with authoritativeAPI:MachineAPI and authoritativeAPI:ClusterAPI, machine's .status.authoritativeAPI are defaulting and setting it to .spec.authoritativeAPI.
  • If machine spec.authoritativeAPI is ClusterAPI, no mapi machine is created. mapi machine paused True.
  • No capi resources will be created in openshift-cluster-api side.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2025 •
edited by openshift-ci bot
Loading

@damdo: This pull request references OCPCLOUD-2986 which is a valid jira issue.

This pull request references OCPCLOUD-2985 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-56849, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Ref: openshift/machine-api-operator#1386

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo
Copy link
Member Author

damdo commented Jul 7, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c0fef7e into openshift:main Jul 7, 2025
9 of 11 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2025

@damdo: Jira Issue OCPBUGS-56849: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-56849 has not been moved to the MODIFIED state.

Details

In response to this:

Ref: openshift/machine-api-operator#1386

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This was referenced Jul 7, 2025
Merged
Merged
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 7, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-provider-gcp
This PR has been included in build ose-machine-api-provider-gcp-container-v4.20.0-202507071217.p0.gc0fef7e.assembly.stream.el9.
All builds following this will include this PR.

@sunzhaohua2
Copy link

sunzhaohua2 commented Jul 8, 2025

raised pr to fix the regression failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@RadekManak RadekManak Awaiting requested review from RadekManak

@sub-mod sub-mod Awaiting requested review from sub-mod

Assignees

@RadekManak RadekManak

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@damdo @openshift-ci-robot @RadekManak @sunzhaohua2 @openshift-bot