OCPBUGS-74076: Fix: Enable boot diagnostics for Azure Stack Hub VMs by gpei · Pull Request #182 · openshift/machine-api-provider-azure

gpei · 2026-01-25T11:30:59Z

The deriveVirtualMachineParametersStackHub function was missing the DiagnosticsProfile field assignment, causing boot diagnostics to not be applied to Azure Stack Hub VMs even when correctly specified in the Machine configuration.

openshift-ci-robot · 2026-01-25T11:31:05Z

@gpei: This pull request references Jira Issue OCPBUGS-74076, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The deriveVirtualMachineParametersStackHub function was missing the DiagnosticsProfile field assignment, causing boot diagnostics to not be applied to Azure Stack Hub VMs even when correctly specified in the Machine configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gpei · 2026-01-25T11:32:08Z

/jira refresh

openshift-ci-robot · 2026-01-25T11:32:16Z

@gpei: This pull request references Jira Issue OCPBUGS-74076, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gpei · 2026-01-25T11:39:16Z

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 openshift/installer#10224

openshift-ci · 2026-01-25T11:39:19Z

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7aeec980-f9e2-11f0-8f5e-f212ccafe468-0

gpei · 2026-01-27T00:23:12Z

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 openshift/installer#10224

openshift-ci · 2026-01-27T00:23:46Z

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5deb7650-fb16-11f0-89d1-164b85f8b486-0

sunzhaohua2 · 2026-01-27T01:39:49Z

@gpei For storageAccountType: CustomerManaged, it work as expected.

          diagnostics:
            boot:
              customerManaged:
                storageAccountURI: https://imageregistryzhsuna9wjrk.blob.mtcazs.wwtatc.com/
              storageAccountType: CustomerManaged

# az vm show --name zhsun-ashfix-cjhqf-worker-mtcazs2-b8v6g -g zhsun-ashfix-cjhqf-rg --query 'diagnosticsProfile.bootDiagnostics'
{
 "enabled": true,
 "storageUri": "https://imageregistryzhsuna9wjrk.blob.mtcazs.wwtatc.com/"
}

For storageAccountType: AzureManaged machine creation failed with incorrect message, ASH does not support AzureManaged boot diagnostics storage. I created a bug https://issues.redhat.com/browse/OCPBUGS-74573

          diagnostics:
            boot:
              storageAccountType: AzureManaged

        RESPONSE 400: 400 Bad Request
        ERROR CODE: InvalidParameter
        --------------------------------------------------------------------------------
        {
          "error": {
            "code": "InvalidParameter",
            "message": "Required parameter 'bootDiagnostics.storageAccountUri' is missing (null).",
            "target": "bootDiagnostics.storageAccountUri"
          }
        }

gpei · 2026-01-27T02:05:38Z

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 openshift/installer#10224

openshift-ci · 2026-01-27T02:05:42Z

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ad7b9fc0-fb24-11f0-91b5-be2c7e67fc22-0

gpei · 2026-01-27T07:37:33Z

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28 openshift/installer#10224

openshift-ci · 2026-01-27T07:37:36Z

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0b6fd0a0-fb53-11f0-9560-fddbdd6f5af8-0

damdo

/approve
/lgtm

openshift-ci · 2026-02-04T16:26:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

damdo · 2026-02-04T21:11:25Z

/hold

Until we decide what to do with: https://issues.redhat.com/browse/OCPBUGS-74573

damdo · 2026-02-04T21:11:39Z

^ cc. @gpei

gpei · 2026-02-05T01:30:03Z

@damdo Thanks for the review and reminding.
Regarding the validation of the diagnostics profile configuration, it should be added in https://github.com/openshift/machine-api-provider-azure/blob/main/pkg/cloud/azure/actuators/machine/reconciler.go#L912, right?
If so, I'd prefer to merge the current PR first, since it fixes the two supported boot-diagnostics strategies on ASH: UserManaged and Disabled. For the AzureManaged type, which is not supported for ASH, I think the validation can be added in a separate PR, specifically for OCPBUGS-74573.
I should have time to work on this during next week's Shift week. WDYT?

damdo · 2026-02-25T08:53:43Z

@gpei Thanks! Merging this first and following up with https://issues.redhat.com/browse/OCPBUGS-74573 SGTM!

Are you still able to have a look at fixing https://issues.redhat.com/browse/OCPBUGS-74573? Thanks!

/unhold

damdo · 2026-02-25T08:55:09Z

@sunzhaohua2 are you happy with that? If so, would you be able to add /verified? Thanks!

gpei · 2026-02-25T09:07:03Z

Are you still able to have a look at fixing https://issues.redhat.com/browse/OCPBUGS-74573? Thanks!

@damdo Hi, I've raised #183 for OCPBUGS-74573, could you please help to take a look when you got a chance. That PR was generally written by Claude, especially for the unit test part.

damdo · 2026-03-07T16:15:11Z

Thanks @gpei, feel free to coordinate with @sunzhaohua2 and @huali9 for verification

sunzhaohua2 · 2026-03-09T08:36:02Z

/verified by @sunzhaohua2
#182 (comment)

openshift-ci-robot · 2026-03-09T08:36:14Z

@sunzhaohua2: This PR has been marked as verified by @sunzhaohua2.

Details

In response to this:

/verified by @sunzhaohua2
#182 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gpei · 2026-03-09T13:21:15Z

/test e2e-azure-operator

openshift-ci · 2026-03-09T15:02:21Z

@gpei: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-03-09T15:04:58Z

@gpei: Jira Issue Verification Checks: Jira Issue OCPBUGS-74076
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-74076 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

The deriveVirtualMachineParametersStackHub function was missing the DiagnosticsProfile field assignment, causing boot diagnostics to not be applied to Azure Stack Hub VMs even when correctly specified in the Machine configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-03-10T19:44:46Z

Fix included in accepted release 4.22.0-0.nightly-2026-03-10-100251

Fix: Enable boot diagnostics for Azure Stack Hub VMs

1e13f80

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 25, 2026

openshift-ci bot requested review from RadekManak and mdbooth January 25, 2026 11:31

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 25, 2026

openshift-ci bot requested a review from sunzhaohua2 January 25, 2026 11:32

openshift-ci bot mentioned this pull request Jan 25, 2026

OCPBUGS-67816: Revert storage account API version for client openshift/installer#10224

Merged

damdo reviewed Feb 4, 2026

View reviewed changes

openshift-ci bot assigned damdo Feb 4, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2026

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2026

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 9, 2026

openshift-merge-bot bot merged commit 178e7d8 into openshift:main Mar 9, 2026
9 checks passed

Conversation

gpei commented Jan 25, 2026

Uh oh!

openshift-ci-robot commented Jan 25, 2026

Uh oh!

gpei commented Jan 25, 2026

Uh oh!

openshift-ci-robot commented Jan 25, 2026

Uh oh!

gpei commented Jan 25, 2026

Uh oh!

openshift-ci bot commented Jan 25, 2026

Uh oh!

gpei commented Jan 27, 2026

Uh oh!

openshift-ci bot commented Jan 27, 2026

Uh oh!

sunzhaohua2 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpei commented Jan 27, 2026

Uh oh!

openshift-ci bot commented Jan 27, 2026

Uh oh!

gpei commented Jan 27, 2026

Uh oh!

openshift-ci bot commented Jan 27, 2026

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 4, 2026

Uh oh!

damdo commented Feb 4, 2026

Uh oh!

damdo commented Feb 4, 2026

Uh oh!

gpei commented Feb 5, 2026

Uh oh!

damdo commented Feb 25, 2026

Uh oh!

damdo commented Feb 25, 2026

Uh oh!

gpei commented Feb 25, 2026

Uh oh!

damdo commented Mar 7, 2026

Uh oh!

sunzhaohua2 commented Mar 9, 2026

Uh oh!

openshift-ci-robot commented Mar 9, 2026

Uh oh!

gpei commented Mar 9, 2026

Uh oh!

openshift-ci bot commented Mar 9, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 9, 2026

Uh oh!

openshift-merge-robot commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sunzhaohua2 commented Jan 27, 2026 •

edited

Loading