Skip to content

Comments

[OCPCLOUD-1371] Refactor provider status to use metav1.Condition#16

Merged
openshift-merge-robot merged 2 commits intoopenshift:mainfrom
RadekManak:condition_refactor
Mar 31, 2022
Merged

[OCPCLOUD-1371] Refactor provider status to use metav1.Condition#16
openshift-merge-robot merged 2 commits intoopenshift:mainfrom
RadekManak:condition_refactor

Conversation

@RadekManak
Copy link
Contributor

@RadekManak RadekManak commented Mar 29, 2022

This PR bumps openshift/api to the latest version with condition changes and refactors this provider to use metav1.Condition.

API change PR (merged): openshift/api#1135

@openshift-ci openshift-ci bot requested review from enxebre and lobziik March 29, 2022 09:13
elmiko
elmiko reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, i don't think the failing e2e it related, but we'll see ;)

/approve

@elmiko
Copy link
Contributor

elmiko commented Mar 29, 2022

/test e2e-azure

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
alexander-demicev
alexander-demicev approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 242163c into openshift:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@lobziik lobziik Awaiting requested review from lobziik

2 more reviewers

@elmiko elmiko elmiko left review comments

@alexander-demicev alexander-demicev alexander-demicev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexander-demicev alexander-demicev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RadekManak @elmiko @alexander-demicev @openshift-merge-robot