Makefile: add Go debug support for local binaries #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
paulfantom
reviewed
Oct 15, 2018
Makefile
Outdated
| @@ -1,8 +1,13 @@ | |||
| DBG ?= 1 | |||
Contributor
There was a problem hiding this comment.
Should it be enabled by default?
Contributor
Author
There was a problem hiding this comment.
Should it be enabled by default?
Argh! Left over from my testing...
Contributor
Author
There was a problem hiding this comment.
Should it be enabled by default?
Fixed.
Invoking the following:
$ make build DBG=1
$ make nodelink-controller DBG=1
$ make test-e2e DBG=1
will build the respective binaries with Go debug support. The build
rules for those three targets are now `go build $(GOGCFLAGS) ...`.
The default value for GOGCFLAGS is -gcflags=all="-N -l", assuming
GOGCFLAGS it not already set in your environment. "all" specifies that
the flags should be applied to all packages (and may rebuild existing
up to date packages); "-N" disables compiler optimisations and "-l"
prevents inlining.
So, to override the defaults:
$ make build DBG=1 GOGCFLAGS='-gcflags="-N -l"'
frobware
force-pushed
the
add-dbg-support
branch
from
7b0ec95 to
348a703
Compare
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/lgtm |
ingvagabund
pushed a commit
to ingvagabund/machine-api-operator
that referenced
this pull request
Jul 11, 2019
remove log-level option
germanparente
pushed a commit
to germanparente/machine-api-operator
that referenced
this pull request
Sep 23, 2025
Add liveness/readiness probes
germanparente
pushed a commit
to germanparente/machine-api-operator
that referenced
this pull request
Sep 23, 2025
…enshift-4.19-ose-machine-api-provider-gcp OCPBUGS-45733: Updating ose-machine-api-provider-gcp-container image to be consistent with ART for 4.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking the following:
will build the respective binaries with Go debug support. The build
rules for those three targets are now
go build $(GOGCFLAGS) ....The default value for GOGCFLAGS is -gcflags=all="-N -l", assuming
GOGCFLAGS it not already set in your environment. "all" specifies that
the flags should be applied to all packages (and may rebuild existing
up to date packages); "-N" disables compiler optimisations and "-l"
prevents inlining.
So, to override the defaults: