Bug 1883497: Fix missing logs due to mixed klog versions #714
Conversation
This makes klog consistent with the core of the Kubernetes project (as of v1.19) which used klog/v2. While on differing versions we will lose logs (only one version will bind the correct flag value) so we should upgrade to v2 to ensure all logs are being printed correctly.
openshift-ci-robot
added
bugzilla/severity-high
|
@JoelSpeed: This pull request references Bugzilla bug 1883497, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
requested review from
alexander-demicev and
michaelgugino
|
/hold until the dependent PRs are merged and the dependencies are updated back to the openshift forks |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel This is now ready to merge |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demichev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
@JoelSpeed: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@JoelSpeed: All pull requests linked via external trackers have merged:
Bugzilla bug 1883497 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
This makes klog consistent with the core of the Kubernetes project (as
of v1.19) which used klog/v2.
While on differing versions we will lose logs (only one version will
bind the correct flag value) so we should upgrade to v2 to ensure all
logs are being printed correctly.