Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 14, 2020

The machine-api runs an approver for CSRs from nodes. Some failure modes results in the CSRs not being approved. This change ensures CSRs are collected for determining whether the CSR itself is malformed or whether the approver is malfunctioning.

@openshift-ci-robot
Copy link
Contributor

@deads2k: This pull request references Bugzilla bug 1878129, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

bug 1878129: add CSRs for oc adm inspect

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign danil-grigorev
You can assign the PR to them by writing /assign @danil-grigorev in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enxebre
Copy link
Member

enxebre commented Sep 14, 2020

This is actually captured by the machine-approver https://github.com/openshift/cluster-machine-approver/blob/4e5ad9c9430c6b6a383dcba86107dff3e64bd686/status.go#L37.
Not sure if we want to have it in two different places.

@openshift-ci-robot
Copy link
Contributor

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/goimports cabc8c9 link /test goimports
ci/prow/unit cabc8c9 link /test unit
ci/prow/e2e-aws-upgrade cabc8c9 link /test e2e-aws-upgrade
ci/prow/e2e-gcp-operator cabc8c9 link /test e2e-gcp-operator
ci/prow/e2e-metal-ipi cabc8c9 link /test e2e-metal-ipi
ci/prow/e2e-aws-operator cabc8c9 link /test e2e-aws-operator
ci/prow/e2e-gcp cabc8c9 link /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 15, 2020

This is actually captured by the machine-approver https://github.com/openshift/cluster-machine-approver/blob/4e5ad9c9430c6b6a383dcba86107dff3e64bd686/status.go#L37.
Not sure if we want to have it in two different places.

is the machine approver in a UPI install?

@enxebre
Copy link
Member

enxebre commented Sep 16, 2020

is the machine approver in a UPI install?

Yes.

@openshift-merge-robot
Copy link
Contributor

@deads2k: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/generate cabc8c9 link /test generate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants