-
Notifications
You must be signed in to change notification settings - Fork 231
bug 1878129: add CSRs for oc adm inspect #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@deads2k: This pull request references Bugzilla bug 1878129, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This is actually captured by the machine-approver https://github.com/openshift/cluster-machine-approver/blob/4e5ad9c9430c6b6a383dcba86107dff3e64bd686/status.go#L37. |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
is the machine approver in a UPI install? |
Yes. |
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The machine-api runs an approver for CSRs from nodes. Some failure modes results in the CSRs not being approved. This change ensures CSRs are collected for determining whether the CSR itself is malformed or whether the approver is malfunctioning.