Skip to content

Add volume mount for libvirt TLS assets #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bison wants to merge 1 commit into from
Closed

Add volume mount for libvirt TLS assets #66

bison wants to merge 1 commit into from

Conversation

@bison
Copy link
Contributor

@bison bison commented Sep 20, 2018

Mounts the libvirt client credentials secret. See: openshift/installer#296

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2018
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 30, 2018

@bison: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2018
frobware
frobware reviewed Oct 1, 2018
View reviewed changes
Copy link
Contributor

@frobware frobware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison, frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bison
Copy link
Contributor Author

bison commented Oct 1, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 2, 2019

@bison: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/go-vet 6ce7a77 link /test go-vet
ci/prow/unit 6ce7a77 link /test unit
ci/jenkins/e2e 6ce7a77 link /test e2e
ci/prow/rhel-images 6ce7a77 link /test rhel-images
ci/prow/e2e-aws-gate 6ce7a77 link /test e2e-aws-gate
ci/prow/e2e-aws-operator 6ce7a77 link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Feb 28, 2019

please re open when relevant

@enxebre enxebre closed this Feb 28, 2019
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
@openshift-merge-robot
Merge pull request openshift#66 from ingvagabund/build-e2e-from-actua…
0989b9e 
…tor-pkg-dep

Build e2e from actuator pkg dep
germanparente pushed a commit to germanparente/machine-api-operator that referenced this pull request Sep 23, 2025
@openshift-merge-robot
Merge pull request openshift#66 from enxebre/fix-1771919
537d68e 
bug 1771919: Consider an instance to exist regardless the status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frobware frobware frobware left review comments

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@frobware frobware

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bison @openshift-bot @openshift-ci-robot @enxebre @frobware