Skip to content

Read Metal3 config from a new CRD #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jan 23, 2020
Merged

Read Metal3 config from a new CRD #470

openshift-merge-robot merged 2 commits into from
Jan 23, 2020

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented Jan 16, 2020 •
edited
Loading

Add functionality for MAO to read provisionings.metal3.io using a dynamic client and updating the baremetal config with config items needed to provision baremetal hosts.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2020
@sadasu sadasu force-pushed the dynamic-client branch 2 times, most recently from ce648a4 to b4bac94 Compare January 17, 2020 09:49
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2020
enxebre
enxebre reviewed Jan 17, 2020
View reviewed changes
enxebre
enxebre reviewed Jan 17, 2020
View reviewed changes
enxebre
enxebre reviewed Jan 17, 2020
View reviewed changes
enxebre
enxebre reviewed Jan 17, 2020
View reviewed changes
enxebre
enxebre reviewed Jan 17, 2020
View reviewed changes
enxebre
enxebre reviewed Jan 17, 2020
View reviewed changes
@sadasu sadasu changed the title WIP: Reading Metal3 config from a new CRD Reading Metal3 config from a new CRD Jan 17, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2020
@sadasu sadasu changed the title Reading Metal3 config from a new CRD WIP: Reading Metal3 config from a new CRD Jan 17, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2020
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2020
@sadasu sadasu changed the title WIP: Reading Metal3 config from a new CRD Reading Metal3 config from a new CRD Jan 17, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sadasu sadasu changed the title Reading Metal3 config from a new CRD Read Metal3 config from a new CRD Jan 22, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member

stbenjam commented Jan 22, 2020

/retest

2 similar comments
@stbenjam
Copy link
Member

stbenjam commented Jan 22, 2020

/retest

@stbenjam
Copy link
Member

stbenjam commented Jan 22, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 062d754 into openshift:master Jan 23, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2020

@sadasu: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 bb81bfc link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre enxebre mentioned this pull request Jan 23, 2020
Closed
@sadasu sadasu deleted the dynamic-client branch January 23, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre enxebre left review comments

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

+1 more reviewer

@bison bison bison approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bison bison

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sadasu @enxebre @openshift-ci-robot @openshift-bot @stbenjam @bison @openshift-merge-robot