-
Notifications
You must be signed in to change notification settings - Fork 231
Expose a dynamic client in the Operator struct #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a dynamic client in the Operator struct #469
Conversation
This is so baremetal can fetch the provisioning.metal3.io object and parametarise their deployment. Related openshift/api#540 and openshift#460
|
cc @sadasu you can then just fetch the provisioning object and parameterise the baremetal deployment at your convenience. Once all get merged please make sure to reflect the latest discussions here https://github.com/openshift/enhancements/blob/master/enhancements/baremetal/baremetal-provisioning-config.md |
bison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bison The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@enxebre: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Alternative in case we transition the baremetal components into its own operator to watch these resources https://github.com/openshift/machine-api-operator/compare/master...enxebre:dynamic-informer?expand=1 |
This is so baremetal can fetch the
provisioning.metal3.ioobject and parameterize their deployment. Related openshift/api#540 and #460