Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Oct 4, 2019

Reverts #401

This broke our CI due to metrics collisions, and #403 failed an upgrade test and so is maybe not a complete fix.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign enxebre
You can assign the PR to them by writing /assign @enxebre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Oct 4, 2019

From here:

chart

@smarterclayton
Copy link
Contributor

/retest

1 similar comment
@smarterclayton
Copy link
Contributor

/retest

@wking
Copy link
Member Author

wking commented Oct 5, 2019

If upgrade was the only thing failing, we might want to green-button (could be dying launching the broken master before starting the upgrade).

@wking
Copy link
Member Author

wking commented Oct 5, 2019

From here:

Oct 04 18:59:34.900 E clusteroperator/machine-api changed Degraded to True: SyncingFailed: Failed to resync for operator: 0.0.1-2019-10-04-181539 because timed out waiting for the condition

And from here, 0.0.1-2019-10-04-181539 is the from release.

@openshift-ci-robot
Copy link
Contributor

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade e0cb156 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Oct 5, 2019

#403 landed.

/close

@openshift-ci-robot
Copy link
Contributor

@wking: Closed this PR.

Details

In response to this:

#403 landed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the revert-401-bump-kube-1.16.0 branch October 5, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants