Go modules #399
Merged
Go modules #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/hold |
openshift-ci-robot
added
size/XXL
openshift-ci-robot
requested review from
michaelgugino and
vikaschoudhary16
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Member
Author
|
/test e2e-aws-upgrade |
Member
Author
|
/test e2e-azure-operator |
Closed
bison
approved these changes
Sep 30, 2019
Contributor
bison
left a comment
bison
left a comment
There was a problem hiding this comment.
/lgtm
But I think we could drop the script we're copying around and then not having the go install ... bits. We can do that another time though.
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bison The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop dep in favour of go modules
go mod initgo mod tidygo mod vendorUse replace for forks, prometheus.client and code-generator.
Enforce
GO111MODULE=onandGOFLAGS += -mod=vendorvia Make file and DOCKER_CMD