Feature gate support #279
Feature gate support #279
Conversation
Needed to watch and list FeaturesGate objects
- remove the owned-manifests from the Dockerfiles - remove owned-manifests directory - create the machine-api-operator controller via code
Machine-api-operator controller will watch FeatureGate resources and update the deployment accordingly. Currently the only one feature that can be enabled via the FeatureGate object is machine-health-check. To enable it you will need to create FeatureGate object with the content: ```yaml apiVersion: config.openshift.io/v1 kind: FeatureGate metadata: name: machine-api-operator spec: featureSet: "TechPreviewNoUpgrade" ```
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
size/XXL
|
@cynepco3hahue thanks for the PR. |
|
@cynepco3hahue: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| } | ||
| glog.V(4).Infof("Deployment %q is not ready. status: (replicas: %d, updated: %d, ready: %d, unavailable: %d)", d.Name, d.Status.Replicas, d.Status.UpdatedReplicas, d.Status.ReadyReplicas, d.Status.UnavailableReplicas) | ||
| return false, nil | ||
| }) |
There was a problem hiding this comment.
this is nice, thanks! can we get it to a different PR?
|
Depends on #280 |
|
Not relevant anymore. |
4 participants
Machine-api-operator controller will watch
FeatureGateresources and update the deployment accordingly.Currently, the only feature that can be enabled via the
FeatureGateobject is machine-health-check. To enable it you will need to create FeatureGate object with the content:TODO:
MachineHealthChecke2e tests to create feature gate before the test and wait for controllers