Skip to content

operator: use infrastructure.config.openshfit.io for platformtype #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Apr 1, 2019
Merged

operator: use infrastructure.config.openshfit.io for platformtype #264

openshift-merge-robot merged 3 commits into from
Apr 1, 2019

Conversation

@enxebre
Copy link
Member

@enxebre enxebre commented Apr 1, 2019 •
edited
Loading

cluster operators must use the config.openshit.io as source for their top level config.
Rebase and follow up for #256

@abhinavdahiya @enxebre
operator: use infrastructure.config.openshfit.io for platformtype
2775ea1 
cluster operators must use the config.openshit.io as source for their top level config.
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 1, 2019
@enxebre enxebre added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2019
@enxebre enxebre changed the title DO NOT MERGE - Test operator: use infrastructure.config.openshfit.io for platformtype Apr 1, 2019
@enxebre enxebre mentioned this pull request Apr 1, 2019
Closed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2019 •
edited
Loading

@enxebre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 4307ea7 link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bison
bison approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2019
@enxebre enxebre removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2019
michaelgugino
michaelgugino suggested changes Apr 1, 2019
View reviewed changes
README.md
kind: Infrastructure
metadata:
name: cluster
status:
Copy link
Contributor

@michaelgugino michaelgugino Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be status or spec? Seems configurables should be in spec not status.

Copy link
Member Author

@enxebre enxebre Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are just consumers here https://github.com/openshift/installer/blob/master/pkg/asset/manifests/infrastructure.go#L67

@michaelgugino
Copy link
Contributor

michaelgugino commented Apr 1, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9382723 into openshift:master Apr 1, 2019
@enxebre enxebre mentioned this pull request Apr 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spangenberg spangenberg Awaiting requested review from spangenberg

2 more reviewers

@bison bison bison approved these changes

@michaelgugino michaelgugino michaelgugino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bison bison

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@enxebre @openshift-ci-robot @michaelgugino @bison @openshift-merge-robot @abhinavdahiya