Skip to content

Stop using static tls data #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trawler wants to merge 1 commit into from
Closed

Stop using static tls data #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions manifests/clusterapi-apiserver-secret.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion manifests/clusterapi-apiserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,5 +110,5 @@ spec:
emptyDir: {}
- name: cluster-apiserver-certs
secret:
secretName: cluster-apiserver-secrets
secretName: cluster-apiserver-certs
Copy link
Member

@enxebre enxebre Aug 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify this consitently work? iirc there was some issue with previews name so vaguely this did not return empty as expected https://github.com/openshift/machine-api-operator/blob/master/vendor/github.com/coreos-inc/tectonic-operators/x-operator/pkg/xoperator/update.go#L114 so then this https://github.com/openshift/machine-api-operator/blob/master/vendor/github.com/coreos-inc/tectonic-operators/x-operator/pkg/xoperator/update.go#L125 and https://github.com/openshift/machine-api-operator/blob/master/vendor/github.com/coreos-inc/tectonic-operators/x-operator/pkg/xoperator/component.go#L194 fails to read

# TODO: add readiness and liveness probe
4 changes: 1 addition & 3 deletions manifests/clusterapi-apiservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@ spec:
version: v1alpha1
group: cluster.k8s.io
groupPriorityMinimum: 2000
versionPriority: 200
service:
name: clusterapi
namespace: default
versionPriority: 10
caBundle: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUM5RENDQWR5Z0F3SUJBZ0lCQURBTkJna3Foa2lHOXcwQkFRc0ZBREFyTVNrd0p3WURWUVFERXlCamJIVnoKZEdWeVlYQnBMV05sY25ScFptbGpZWFJsTFdGMWRHaHZjbWwwZVRBZUZ3MHhPREEzTVRBd09ETTRORGhhRncweQpPREEzTURjd09ETTRORGhhTUNzeEtUQW5CZ05WQkFNVElHTnNkWE4wWlhKaGNHa3RZMlZ5ZEdsbWFXTmhkR1V0CllYVjBhRzl5YVhSNU1JSUJJakFOQmdrcWhraUc5dzBCQVFFRkFBT0NBUThBTUlJQkNnS0NBUUVBdVR3TGR6NlIKbTVxU20wNC9ES1Y3ZUV1ZnFrQmh0S01GZHM3MGswaUVVWjlKcWpNSWE4cFNkU2dMc3VWQXNwbkVZYmJxcTFUcAp1UVRHbnpoNnRQU2lsRnprOWVlOFUvL0dDQmU5NzhNeXl3emgycFB6WjBGaEZHMzFlaVNycjQrRlUxRFpPVGIwCkFucU9QQzU0QmpUOFZTci9aZm9OZkFoTm9hK1RxeEt4dzdDcDZMbmFLVmkzR3U1SlowSzFVK1Z2bGt6ajhWUGkKU256azMyVDJCZTZEQ0MwTUhYRXlRRXdoWFVrTTg5eTNHMTZtVG12Z0JiSHowU2F6Vjc4UE02b0lUdS9HcmgvLwp2RTVoYUdOcTF0RVY0TTRPMGR5K2k2d01rZU9vV3o1MjA5NjgvQ1VmMHJ3c2ZVMGwxWC9YK1RhTmkrMm4weEh1CkJqSWF5bEZaM3oxbVRRSURBUUFCb3lNd0lUQU9CZ05WSFE4QkFmOEVCQU1DQXFRd0R3WURWUjBUQVFIL0JBVXcKQXdFQi96QU5CZ2txaGtpRzl3MEJBUXNGQUFPQ0FRRUFoVFpMSmtOa0FibDE4b3JEc2ZjeFN5TE40MjREOVltLwpXWVo1d1RpNDdzUHdhcG8yMnpkMXF0N0dDa0MzckJrbkNMbnYvODdCWjcrWmhXR0JrYy8xMjZRUldwTUdoY283Ck4zRWhwNmk5OEo3NEY2UVkzRlhVRk9hNWUwNDdGUkZUOGZ2N2RLQjR6Nm45N05YWE9ZeDJIZ3d6R2ozNGliTGEKZUs3SkorTEUvL3BPT0h6bVF5UDZWdkU4ak91MDBXNW0xTGpsT0xsbzZ5MXpzajV5c2FvM3krUU90SjUvVUY1NQp3cWVWRW1uOVNxWTZEemp3ZWNoelU3OGFtN1I2end1ZzM1RWp0YTUvbVNvTGlBU0VtcEVTQ1hJUkhiK3BLSXNoCjZFRmNXbFAvcWNnbjVnZEk2aFBodlVwc1l5a2RMWHpQd1VKUVJLYnVPNWVGUGxBUzAzR2QzZz09Ci0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
# TODO: generate this dynamically
insecureSkipTLSVerify: true
Copy link
Member

@enxebre enxebre Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?