SPLAT-2167: Added logic to webhook for AWS dedicated host support

[vr4manta]

SPLAT-2167

Changes

• Added logic to webhook to validate fields are correct

Dependencies

• SPLAT-2206: Added AWS dedicated host support api#2484

Notes

Original PR was reverted due to attempt to reduce e2e dependency complexity. Removed that work to attempt in a different PR.

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2167 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2167

Changes

• Added logic to webhook to validate fields are correct

Dependencies

• SPLAT-2206: Added AWS dedicated host support api#2484

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2167 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2167

Changes

• Added logic to webhook to validate fields are correct

Dependencies

• SPLAT-2206: Added AWS dedicated host support api#2484

Notes

Original PR was reverted due to attempt to reduce e2e dependency complexity. Removed that work to attempt in a different PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vr4manta]

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-dedicated periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn

[openshift-ci]

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-dedicated

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f84cd290-c3b0-11f0-9160-7f10bdfdfefe-0

[vr4manta]

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn

[openshift-ci]

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ff7b5aa0-c3b0-11f0-9c6e-d2107bd263d3-0

[vr4manta]

Running the unit tests local they pass. I am gonna check to see if I can recreate the failure for:

--- FAIL: TestReconcile (2.70s)
    --- PASS: TestReconcile/machine_unhealthy (1.79s)
    --- PASS: TestReconcile/machine_unhealthy,_MHC_paused (0.06s)
    --- PASS: TestReconcile/machine_with_node_healthy (0.06s)
    --- PASS: TestReconcile/machine_with_node_healthy_but_external_remediation_annotation (0.08s)
    --- FAIL: TestReconcile/machine_with_node_likely_to_go_unhealthy (0.14s)
    --- PASS: TestReconcile/no_target:_no_machine_and_bad_node_annotation (0.13s)
    --- PASS: TestReconcile/no_target:_no_machine (0.04s)
    --- PASS: TestReconcile/machine_no_controller_owner (0.07s)
    --- PASS: TestReconcile/machine_no_noderef (0.14s)
    --- PASS: TestReconcile/machine_already_deleted (0.08s)
    --- PASS: TestReconcile/machine_healthy_with_MHC_negative_maxUnhealthy (0.04s)
    --- PASS: TestReconcile/machine_unhealthy_with_MHC_negative_maxUnhealthy (0.06s)
...
There were failures detected in the following suites:
  machinehealthcheck ./pkg/controller/machinehealthcheck
Test Suite Failed
exit status 1

[jcpowermac]

/test unit

[openshift-ci]

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jcpowermac]

/lgtm

[vr4manta]

/assign @damdo

[vr4manta]

/assign @JoelSpeed

[damdo]

/approve

Thanks

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vr4manta]

/verified by @vr4manta
Verified using manual testing until installer PR is merged to allow periodical to fully work.

[openshift-ci-robot]

@vr4manta: This PR has been marked as verified by @vr4manta.

In response to this:

/verified by @vr4manta
Verified using manual testing until installer PR is merged to allow periodical to fully work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.