OCPCLOUD-3173: Validating webhooks for GCP ProvisioningModel #1428
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@RadekManak: This pull request references OCPCLOUD-3173 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
go.mod
Outdated
| // an API yet we can leverage so that I do not have to copy what openshift/kubernetes/openshift-hack/cmd/k8s-tests-ext did to initialize. | ||
| replace ( | ||
| github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20241205171354-8006f302fd12 | ||
| github.com/openshift/api => github.com/radekmanak/api v0.0.0-20251104154716-52bc7547ff1d |
There was a problem hiding this comment.
TODO: this will need changing once the API has merged.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@RadekManak: This pull request references OCPCLOUD-3173 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@RadekManak: This pull request references OCPCLOUD-3173 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
pkg/webhooks/machine_webhook.go
Outdated
| errs = append(errs, field.Invalid(field.NewPath("providerSpec", "restartPolicy"), providerSpec.RestartPolicy, fmt.Sprintf("restartPolicy must be either %s or %s.", machinev1beta1.RestartPolicyNever, machinev1beta1.RestartPolicyAlways))) | ||
| } | ||
|
|
||
| if providerSpec.ProvisioningModel != "" && providerSpec.ProvisioningModel != machinev1beta1.GCPSpotInstance { |
There was a problem hiding this comment.
We don't actually want to allow "", which means this field needs to be a pointer. Only valid choices should be nil and "Spot"
|
@RadekManak: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
This PR adds validating webhook for new ProvisioningModel field.
These two validations are added:
Note: This is using my fork of the API PR, but the contents are the same as the API PR.