Skip to content

Add Machine webhook to validate the new fields of NutanixMachineProviderConfig #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Feb 16, 2023
Merged

Add Machine webhook to validate the new fields of NutanixMachineProviderConfig #1117

openshift-merge-robot merged 2 commits into from
Feb 16, 2023

Conversation

@yanhua121
Copy link
Contributor

@yanhua121 yanhua121 commented Feb 7, 2023 •
edited
Loading

  1. Revendor the openshift/api for the newly added NutanixMachineProviderConfig fields: Add optional new fields to NutanixMachineProviderConfig api#1390
  2. Add Machine webhook to validate the new fields of NutanixMachineProviderConfig

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2023
@openshift-ci openshift-ci bot requested review from elmiko and lobziik February 7, 2023 21:42
@yanhua121 yanhua121 mentioned this pull request Feb 7, 2023
Merged
@yanhua121 yanhua121 force-pushed the nutanix-machine-webhook branch from 11b35c7 to 475b179 Compare February 7, 2023 21:58
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2023
@yanhua121 yanhua121 force-pushed the nutanix-machine-webhook branch 4 times, most recently from 6eebde5 to 395794d Compare February 10, 2023 19:46
@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 14, 2023

/test e2e-nutanix

elmiko
elmiko reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, just a comment about one of the error messages

@yanhua121 yanhua121 force-pushed the nutanix-machine-webhook branch from 395794d to 3809df7 Compare February 15, 2023 16:38
elmiko
elmiko reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JoelSpeed ptal

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 15, 2023

/retest-required

@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 15, 2023

/test e2e-nutanix

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Feb 16, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 16, 2023

/retest-required

Remaining retests: 0 against base HEAD 9d54a2c and 2 for PR HEAD 3809df7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2023

@yanhua121: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upgrade 3809df7 link false /test e2e-vsphere-ovn-upgrade
ci/prow/e2e-metal-ipi-virtualmedia 3809df7 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-azure-operator 3809df7 link false /test e2e-azure-operator
ci/prow/e2e-gcp-ovn 3809df7 link false /test e2e-gcp-ovn
ci/prow/e2e-openstack 3809df7 link false /test e2e-openstack
ci/prow/e2e-libvirt 3809df7 link false /test e2e-libvirt
ci/prow/e2e-nutanix 3809df7 link false /test e2e-nutanix
ci/prow/e2e-vsphere-ovn-serial 3809df7 link false /test e2e-vsphere-ovn-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4b14541 into openshift:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lobziik lobziik Awaiting requested review from lobziik

1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yanhua121 @JoelSpeed @openshift-ci-robot @elmiko @openshift-merge-robot