Skip to content

Comments

[OCPCLOUD-1371] Refactor provider status to use metav1.Condition#1004

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
RadekManak:condition_refactor
Mar 31, 2022
Merged

[OCPCLOUD-1371] Refactor provider status to use metav1.Condition#1004
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
RadekManak:condition_refactor

Conversation

@RadekManak
Copy link
Contributor

This PR bumps openshift/api to the latest version with condition changes and refactors this provider to use metav1.Condition.

API change PR (merged): openshift/api#1135

@openshift-ci openshift-ci bot requested review from Fedosin and lobziik March 29, 2022 09:14
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

@RadekManak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia 8756509 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-ovn-dualstack 8756509 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi 8756509 link false /test e2e-metal-ipi
ci/prow/e2e-aws-disruptive 8756509 link false /test e2e-aws-disruptive
ci/prow/e2e-azure 8756509 link false /test e2e-azure
ci/prow/e2e-metal-ipi-upgrade 8756509 link false /test e2e-metal-ipi-upgrade
ci/prow/e2e-azure-operator 8756509 link false /test e2e-azure-operator
ci/prow/e2e-openstack 8756509 link false /test e2e-openstack
ci/prow/e2e-metal-ipi-ovn-ipv6 8756509 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-libvirt 8756509 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lobziik
Copy link
Contributor

lobziik commented Mar 31, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit eb5fce7 into openshift:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants