-
Notifications
You must be signed in to change notification settings - Fork 231
Crds #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Crds #100
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c216516
revendor cluster api
enxebre 85649db
update owned manifests for CRDs
enxebre 3ae75a8
drop api server in favour of CRDs in sync loops
enxebre 8df24f5
update tests for CRDs
enxebre c62c337
update actuator images for CRDs
enxebre 32545b0
update unit test
enxebre 0d024ab
bump to images build by CI
enxebre 3a9961e
update for CRD libvirt image
enxebre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| apiVersion: apiextensions.k8s.io/v1beta1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| creationTimestamp: null | ||
| labels: | ||
| controller-tools.k8s.io: "1.0" | ||
| name: clusters.cluster.k8s.io | ||
| spec: | ||
| group: cluster.k8s.io | ||
| names: | ||
| kind: Cluster | ||
| plural: clusters | ||
| scope: Namespaced | ||
| subresources: | ||
| status: {} | ||
| validation: | ||
| openAPIV3Schema: | ||
| properties: | ||
| apiVersion: | ||
| type: string | ||
| kind: | ||
| type: string | ||
| metadata: | ||
| type: object | ||
| spec: | ||
| properties: | ||
| clusterNetwork: | ||
| properties: | ||
| pods: | ||
| properties: | ||
| cidrBlocks: | ||
| items: | ||
| type: string | ||
| type: array | ||
| required: | ||
| - cidrBlocks | ||
| type: object | ||
| serviceDomain: | ||
| type: string | ||
| services: | ||
| properties: | ||
| cidrBlocks: | ||
| items: | ||
| type: string | ||
| type: array | ||
| required: | ||
| - cidrBlocks | ||
| type: object | ||
| required: | ||
| - services | ||
| - pods | ||
| - serviceDomain | ||
| type: object | ||
| providerConfig: | ||
| properties: | ||
| value: | ||
| type: object | ||
| valueFrom: | ||
| type: object | ||
| type: object | ||
| required: | ||
| - clusterNetwork | ||
| type: object | ||
| status: | ||
| properties: | ||
| apiEndpoints: | ||
| items: | ||
| properties: | ||
| host: | ||
| type: string | ||
| port: | ||
| format: int64 | ||
| type: integer | ||
| required: | ||
| - host | ||
| - port | ||
| type: object | ||
| type: array | ||
| errorMessage: | ||
| type: string | ||
| errorReason: | ||
| type: string | ||
| providerStatus: | ||
| type: object | ||
| type: object | ||
| version: v1alpha1 | ||
| status: | ||
| acceptedNames: | ||
| kind: "" | ||
| plural: "" | ||
| conditions: [] | ||
| storedVersions: [] |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
14 changes: 0 additions & 14 deletions
14
owned-manifests/clusterapi-controller-cluster-role-binding.yaml
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
7 changes: 3 additions & 4 deletions
7
...erapi-apiserver-cluster-role-binding.yaml → ...sterapi-manager-cluster-role-binding.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,12 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: "clusterapi:apiserver-auth-delegator" | ||
| name: cluster-api-manager-rolebinding | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: system:auth-delegator | ||
| name: cluster-api-manager-role | ||
| subjects: | ||
| - apiGroup: "" | ||
| kind: ServiceAccount | ||
| - kind: ServiceAccount | ||
| name: default | ||
| namespace: {{ .TargetNamespace }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well:
machine-api-operator/tests/e2e/manifests/images.configmap.yaml
Lines 10 to 11 in 3a9961e
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! fyi that does not have any effect, libvirt is not being tested here. We need to add framework like testing in this repo. After merging this we need to wait for it to be part of the payload.
Then we can get the aws crd pr green.
And then we need to put the real images name here back to 4.0.0