Skip to content

Set TCP_USER_TIMEOUT socket option#978

Merged
openshift-merge-robot merged 4 commits intoopenshift:release-4.4from
p0lyn0mial:release-4.4-tcp-usr-timeout
Jan 11, 2021
Merged

Set TCP_USER_TIMEOUT socket option#978
openshift-merge-robot merged 4 commits intoopenshift:release-4.4from
p0lyn0mial:release-4.4-tcp-usr-timeout

Conversation

@p0lyn0mial
Copy link
Contributor

clean pick from #967

wrapping the DialContext method and setting the socket options on a copy of the file descriptor is not deterministic.
as per documentation attempting to change properties of the original using this duplicate
may or may not have the desired effect.

instead we should set the options on the original file descriptor.
@openshift-ci-robot
Copy link

@p0lyn0mial: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Set TCP_USER_TIMEOUT socket option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Contributor Author

/assign @sttts

@sttts
Copy link
Contributor

sttts commented Jan 11, 2021

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit 993204e into openshift:release-4.4 Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants