config: add status helper funcs for v1.ClusterOperator

[abhinavdahiya]

These functions currently exist in https://github.com/openshift/cluster-version-operator/blob/0eaaaa01e881933223f5afcb57de73dbaf793b54/lib/resourcemerge/os.go#L36-L109.
This removes dependency of operators from cvo completely.

@deads2k hopefully this import github.com/library-go/pkg/config/clusteroperator/v1 is sane for getting these functions on ClusterOperatorStatus.

/cc @smarterclayton @deads2k

[abhinavdahiya]

ping :)

[deads2k]

You sure want this or want to simply update the ClusterOperator resource to use the operator/v1 conditions?

[abhinavdahiya]

You sure want this or want to simply update the ClusterOperator resource to use the operator/v1 conditions?

Either is fine. I don't have any strong prefs on that, whatever you think is more correct.
/cc @smarterclayton

[deads2k]

Either is fine. I don't have any strong prefs on that, whatever you think is more correct.
/cc @smarterclayton

I think we should collapse our status conditions into a single type. It's a quick change in openshift/api and doesn't affect serialization in any serious way.

[abhinavdahiya]

@deads2k
https://github.com/openshift/api/blob/master/operator/v1/register.go#L13 prevents us from using operatorv1.OperatorCondition in configv1.ClusterOperator.Status.Conditions (import cycle)

Is other way around ie moving operatorv1.OperatorCondition to configv1 acceptable?

[deads2k]

@deads2k
https://github.com/openshift/api/blob/master/operator/v1/register.go#L13 prevents us from using operatorv1.OperatorCondition in configv1.ClusterOperator.Status.Conditions (import cycle)

Is other way around ie moving operatorv1.OperatorCondition to configv1 acceptable?

I won't hold this up on that. I'm personally disinclined to move it in that direction.

/lgtm
/hold

holding for nits (at least the order). Feel free to self-tag after that.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[abhinavdahiya]

Feel free to self-tag after that.

Adding the lgtm label manually as @deads2k allowed me to do it. 😇