Bug 1905119: csi: allow for custom string replaces in controller asset

[staebler]

To support AWS C2S, the AWS EBS CSI driver needs to be able to modify the controller deployment that it creates based upon whether there is a custom CA bundle to use when accessing the AWS API.

[openshift-ci-robot]

@staebler: This pull request references Bugzilla bug 1905119, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1905119: csi: allow for custom string replaces in controller asset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: staebler
To complete the pull request process, please assign deads2k after the PR has been reviewed.
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[staebler]

/cc @bertinatto

[bertinatto]

/assign @deads2k

[bertinatto]

There's another bug where we also need to modify the controller Deployment (i.e., by adding some annotations to it), but string replacements aren't a good fit for that.

I'm working on a PR to add a hook to modify the Deployment object instead: openshift/aws-ebs-csi-driver-operator#104. I think we could use that to add the custom CA bundle. Any thoughts?

CC @jsafrane

[staebler]

This is obsolete.
/close

[openshift-ci-robot]

@staebler: Closed this PR.

Details

In response to this:

This is obsolete.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@staebler: This pull request references Bugzilla bug 1905119. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1905119: csi: allow for custom string replaces in controller asset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.