[release-4.3] Update Apply{DaemonSet,Deployment} to rely on a hash of the spec#801
Conversation
This removes the need for the caller to be able to force a rollout. Any state that is not present in the spec should instead be added as an annotation so that a rollout will occur when the external state changes. This is an intentional breaking change to encourage switching to the revised function. Callers who want to continue using the previous (deprecated) implementation will need to change the name of the function they are calling to ApplyDeploymentWithForce.
This removes the need for the caller to be able to force a rollout. Any state that is not present in the spec should instead be added as an annotation so that a rollout will occur when the external state changes. This is an intentional breaking change to encourage switching to the revised function. Callers who want to continue using the previous (deprecated) implementation will need to change the name of the function they are calling to ApplyDaemonSetWithForce.
|
/retitle [release-4.3] Update Apply{DaemonSet,Deployment} to rely on a hash of the spec |
openshift-ci-robot
changed the title
|
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
6 participants
This is an automated cherry-pick of #782
/assign marun