Skip to content

return an image digest from DockerImageReference string #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sallyom wants to merge 1 commit into from
Closed

return an image digest from DockerImageReference string #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/image/reference/reference.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package reference

import (
"fmt"
"net"
"net/url"
"strings"
Expand Down Expand Up @@ -62,6 +63,19 @@ func Parse(spec string) (DockerImageReference, error) {
return ref, nil
}

// GetSpecDigest returns the image digest from a DockerImageReference string.
// example 'sha:22204fa2...' in an image 'registry/ocp/release@sha:22204fa2...'
func GetSpecDigest(spec string) (string, error) {
Copy link

@soltysh soltysh May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is needed when we can use Parse and then read resulting ref.ID?

Copy link
Contributor Author

@sallyom sallyom May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, closing this lol

namedRef, err := reference.ParseNamed(spec)
if err != nil {
return "", err
}
if named, ok := namedRef.(reference.Digested); ok {
return named.Digest().String(), nil
}
return "", fmt.Errorf("could not parse digest for spec: %v", spec)
}

// Equal returns true if the other DockerImageReference is equivalent to the
// reference r. The comparison applies defaults to the Docker image reference,
// so that e.g., "foobar" equals "docker.io/library/foobar:latest".
Expand Down