Skip to content

Make cluster operator diff messages shorter for events#784

Closed
mfojtik wants to merge 1 commit intoopenshift:masterfrom
mfojtik:fix-cluster-operator-status-diff
Closed

Make cluster operator diff messages shorter for events#784
mfojtik wants to merge 1 commit intoopenshift:masterfrom
mfojtik:fix-cluster-operator-status-diff

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Apr 23, 2020

This will make messages like this shorter:

"Status for clusteroperator/kube-apiserver changed: Degraded message changed from \"NodeControllerDegraded: The master nodes not ready: node \\\"ip-10-0-132-198.us-east-2.compute.internal\\\" not ready since 2020-04-23 08:34:47 +0000 UTC because KubeletNotReady (runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file in /etc/kubernetes/cni/net.d/. Has your network provider started?), node \\\"ip-10-0-159-150.us-east-2.compute.internal\\\" not ready since 2020-04-23 08:34:56 +0000 UTC because KubeletNotReady (runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file in /etc/kubernetes/cni/net.d/. Has your network provider started?)\\nInstallerControllerDegraded: missing required resources: [configmaps: aggregator-client-ca,client-ca, configmaps: bound-sa-token-signing-certs-1,config-1,etcd-serving-ca-1,kube-apiserver-cert-syncer-kubeconfig-1,kube-apiserver-pod-1,kubelet-serving-ca-1,sa-token-signing-certs-1, secrets: aggregator-client,bound-service-account-signing-key,external-loadbalancer-serving-certkey,internal-loadbalancer-serving-certkey,localhost-serving-cert-certkey,service-network-serving-certkey, secrets: etcd-client-1,kubelet-client-1,localhost-recovery-client-token-1,localhost-recovery-serving-certkey-1]\\nCertRotation_KubeControllerManagerClient_Degraded: configmaps \\\"kube-control-plane-signer-ca\\\" already exists\\nRevisionControllerDegraded: configmaps \\\"kube-apiserver-pod\\\" not found\" to \"NodeControllerDegraded: The master nodes not ready: node \\\"ip-10-0-132-198.us-east-2.compute.internal\\\" not ready since 2020-04-23 08:34:47 +0000 UTC because KubeletNotReady (runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file in /etc/kubernetes/cni/net.d/. Has your network provider started?), node \\\"ip-10-0-159-150.us-east-2.compute.internal\\\" not ready since 2020-04-23 08:34:56 +0000 UTC because KubeletNotReady (runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file in /etc/kubernetes/cni/net.d/. Has your network provider started?)\\nInstallerControllerDegraded: missing required resources: [configmaps: aggregator-client-ca,client-ca, configmaps: bound-sa-token-signing-certs-1,config-1,etcd-serving-ca-1,kube-apiserver-cert-syncer-kubeconfig-1,kube-apiserver-pod-1,kubelet-serving-ca-1,sa-token-signing-certs-1, secrets: aggregator-client,bound-service-account-signing-key,external-loadbalancer-serving-certkey,internal-loadbalancer-serving-certkey,localhost-serving-cert-certkey,service-network-serving-certkey, secrets: etcd-client-1,kubelet-client-1,localhost-recovery-client-token-1,localhost-recovery-serving-certkey-1]\\nCertRotation_KubeControllerManagerClient_Degraded: configmaps \\\"kube-control-plane-signer-ca\\\" already exists\\nRevisionControllerDegraded: configmaps \\\"kube-apiserver-pod\\\" not found\\nCertRotation_ExternalLoadBalancerServing_Degraded: configmaps \\\"loadbalancer-serving-ca\\\" already exists\""

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mfojtik
To complete the pull request process, please assign deads2k
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik mfojtik force-pushed the fix-cluster-operator-status-diff branch from d143c6f to bf432b1 Compare April 24, 2020 10:04
@mfojtik mfojtik changed the title Fix cluster operator status diff Make cluster operator diff messages shorter for events Apr 27, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 7, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants