-
Notifications
You must be signed in to change notification settings - Fork 251
Remove bitbucket.org/ww/goautoneg dependency #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bitbucket.org/ww/goautoneg dependency #776
Conversation
|
/assign @deads2k |
It forces ppl to install mercurial. Use instead munnerz github copy of it.
|
Is the copy a fork? Is it maintained? |
It is a fork in that it has one additional patch: munnerz/goautoneg#3 . WRT maintenance, the original hasn't seen any change since 2012: https://bitbucket.org/ww/goautoneg/src/default/
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove bitbucket.org/ww/goautoneg dependency
This bump imports the recent fix in reflector/informer that was made in upstream client-go. See kubernetes/kubernetes@8012722 and kubernetes/kubernetes@744dd65 for more context. This bump also imports a newer version of openshift/library-go to recover an expired dependency. See openshift/library-go#776.
This bump imports the recent fix in reflector/informer that was made in upstream client-go. See kubernetes/kubernetes@8012722 and kubernetes/kubernetes@744dd65 for more context. This bump also imports a newer version of openshift/library-go to recover an expired dependency. See openshift/library-go#776.
openshift/library-go#776 removes the bitbucket.org/ww/goautoneg dependency in favor of an actively maintained fork.
It forces ppl to install mercurial. Use instead munnerz github copy of
it.