Skip to content

Conversation

@alvaroaleman
Copy link
Contributor

It forces ppl to install mercurial. Use instead munnerz github copy of
it.

@alvaroaleman
Copy link
Contributor Author

/assign @deads2k

It forces ppl to install mercurial. Use instead munnerz github copy of
it.
@sttts
Copy link
Contributor

sttts commented Apr 22, 2020

Is the copy a fork? Is it maintained?

@alvaroaleman
Copy link
Contributor Author

alvaroaleman commented Apr 22, 2020

Is the copy a fork? Is it maintained?

It is a fork in that it has one additional patch: munnerz/goautoneg#3 . WRT maintenance, the original hasn't seen any change since 2012: https://bitbucket.org/ww/goautoneg/src/default/

github.com/munnerz/goautoneg is already a transient dependency in this repo because its used in k8s.io/apiserver (introduced in kubernetes/kubernetes#72138): https://github.com/kubernetes/kubernetes/blob/fc9d1741022a8b367e8f91236d0c41111d47684d/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/negotiation/negotiate.go#L25

@sttts
Copy link
Contributor

sttts commented Apr 23, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit d136041 into openshift:master Apr 23, 2020
bertinatto pushed a commit to bertinatto/library-go that referenced this pull request Jul 2, 2020
Remove bitbucket.org/ww/goautoneg dependency
sgreene570 added a commit to sgreene570/cluster-ingress-operator that referenced this pull request Sep 18, 2020
This bump imports the recent fix in reflector/informer
that was made in upstream client-go. See
kubernetes/kubernetes@8012722
and kubernetes/kubernetes@744dd65
for more context.

This bump also imports a newer version of openshift/library-go to
recover an expired dependency. See
openshift/library-go#776.
sgreene570 added a commit to sgreene570/cluster-ingress-operator that referenced this pull request Sep 18, 2020
This bump imports the recent fix in reflector/informer
that was made in upstream client-go. See
kubernetes/kubernetes@8012722
and kubernetes/kubernetes@744dd65
for more context.

This bump also imports a newer version of openshift/library-go to
recover an expired dependency. See
openshift/library-go#776.
sgreene570 added a commit to sgreene570/cluster-ingress-operator that referenced this pull request Sep 18, 2020
openshift/library-go#776
removes the bitbucket.org/ww/goautoneg dependency in favor
of an actively maintained fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants