Skip to content

Bug 1788522: config: default bind network to tcp instead of tcp4 [release-4.3] - #658

Merged
openshift-merge-robot merged 1 commit into
openshift:release-4.3from
openshift-cherrypick-robot:cherry-pick-657-to-release-4.3
Jan 8, 2020
Merged

Bug 1788522: config: default bind network to tcp instead of tcp4 [release-4.3]#658
openshift-merge-robot merged 1 commit into
openshift:release-4.3from
openshift-cherrypick-robot:cherry-pick-657-to-release-4.3

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #657

/assign mfojtik

@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.3] config: default bind network to tcp instead of tcp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 7, 2020
@mfojtik mfojtik changed the title [release-4.3] config: default bind network to tcp instead of tcp4 Bug 1788522: config: default bind network to tcp instead of tcp4 [release-4.3] Jan 7, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 7, 2020
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1788522, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1788522: config: default bind network to tcp instead of tcp4 [release-4.3]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik

mfojtik commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

/bugzilla refresh

@openshift-ci-robot

Copy link
Copy Markdown

@mfojtik: This pull request references Bugzilla bug 1788522, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik

mfojtik commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 7, 2020
@openshift-ci-robot

Copy link
Copy Markdown

@mfojtik: This pull request references Bugzilla bug 1788522, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 7, 2020
@mfojtik

mfojtik commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 7, 2020
@openshift-ci-robot

Copy link
Copy Markdown

@mfojtik: This pull request references Bugzilla bug 1788522, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 7, 2020
@mfojtik

mfojtik commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

@eparis process note... Having a bug with target release 4.3.z results in "invalid-bug" label, however we know this won't be shipped in 4.3.0 because IPv6 is planned for 4.3.z...
Any process clue on how to proceed here?

(also moving this to 4.3.0 means we are going to create blocker that is not really a blocker ;-)

@mfojtik

mfojtik commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

For patch-manager: This is high priority fix, without this we can't bump operators (which will probably take another z-stream) and it means that operators in ipv6 clusters are not reporting metrics and healthz at all (because the HTTP server that does that won't bind on IPv6 interface).

@sttts

sttts commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@openshift-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@mfojtik

mfojtik commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

Overriding the labels manually per slack discussion with Eric. We are going to special-case library-go repository and it won't be necessary to have valid-bug label and cherry-pick approved for backports here.

@mfojtik mfojtik added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 8, 2020
@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 8, 2020
@openshift-merge-robot
openshift-merge-robot merged commit ef35875 into openshift:release-4.3 Jan 8, 2020
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1788522 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1788522: config: default bind network to tcp instead of tcp4 [release-4.3]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants