fileobserver: prometheus counter for observed actions - #654
Merged
Conversation
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
mfojtik
force-pushed
the
observer-metrics
branch
from
January 3, 2020 10:55
7c5653a to
d6dc404
Compare
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
(fixed build error, re-applying lgtm) |
mfojtik
added a commit
to mfojtik/cluster-kube-controller-manager-operator
that referenced
this pull request
Jan 7, 2020
openshift/library-go#657 : config: default bind network to tcp instead of tcp4 openshift/library-go#656 : leaderelection: set release on cancel to true openshift/library-go#654 : fileobserver: prometheus counter for observed actions
mfojtik
added a commit
to mfojtik/cluster-openshift-apiserver-operator
that referenced
this pull request
Jan 7, 2020
openshift/library-go#657 : config: default bind network to tcp instead of tcp4 openshift/library-go#656 : leaderelection: set release on cancel to true openshift/library-go#654 : fileobserver: prometheus counter for observed actions
bertinatto
pushed a commit
to bertinatto/library-go
that referenced
this pull request
Jul 2, 2020
fileobserver: prometheus counter for observed actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add
fileobserver_action_count{name=ACTION, filename="file"}=Nprometheus metric that can be used to track changes on particular files over time and indicate problems when files are changed too often or not changed at all.