Update observe proxy to use Status NoProxy #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the installer creates the Proxy manifest Status NoProxy contains the list of cluster urls and ip address(es) that should not be proxied. Spec noProxy only contains the user provided list.
openshift-ci-robot
added
the
size/S
Contributor
|
/lgtm |
Contributor
|
/lgtm |
mfojtik
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jcpowermac, mfojtik, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
bertinatto
pushed a commit
to bertinatto/library-go
that referenced
this pull request
Jul 2, 2020
Update observe proxy to use Status NoProxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the installer creates the Proxy manifest
Status NoProxy contains the list of cluster urls and
ip address(es) that should not be proxied. Spec noProxy
only contains the user provided list.