configobserver: add helper function for observing the Proxy object#485
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Jul 29, 2019
Merged
configobserver: add helper function for observing the Proxy object#485openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
size/L
Contributor
Author
|
Added a unit test, removed logging on Proxy object not-foud to match the featuregates observer behavior. |
sttts
reviewed
Jul 26, 2019
sttts
reviewed
Jul 26, 2019
sttts
reviewed
Jul 26, 2019
…re object If we got an error while getting the infrastructure/cluster object that's different from NotFound, it should be reported
sttts
reviewed
Jul 29, 2019
| return observedConfig, errs | ||
| } | ||
| if err != nil { | ||
| errs = append(errs, err) |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stlaz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
bertinatto
pushed a commit
to bertinatto/library-go
that referenced
this pull request
Jul 2, 2020
configobserver: add helper function for observing the Proxy object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenShift infrastructure operators should be observing the Proxy object, add a helper so that we can reuse the code.
Useful at least for the kube and openshift apiserver operators.