make functions for easy adoption of rendered certificates #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
Author
|
/hold until I have proof of rendering. |
openshift-ci-robot
added
do-not-merge/hold
Contributor
Author
|
openshift/cluster-kube-apiserver-operator#276 looks good. |
deads2k
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
deads2k
force-pushed
the
adopt-installer-cert
branch
from
3b90cff to
293ab62
Compare
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bertinatto
pushed a commit
to bertinatto/library-go
that referenced
this pull request
Jul 2, 2020
make functions for easy adoption of rendered certificates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us adopt the certs from openshift/installer#1232 into the "normal" rotator. We need to do this the kubelet client cert.
proven in openshift/cluster-kube-apiserver-operator#276
/assign @sttts