Skip to content

NO-JIRA: Rename alias of api/config/v1 - #2198

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
ardaguclu:rename-configv1-package
May 5, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
ardaguclu:rename-configv1-package

Conversation

@ardaguclu

@ardaguclu ardaguclu commented May 5, 2026

Copy link
Copy Markdown
Member

This PR renames alias of github.com/openshift/api/config/v1 package to configv1 per requested in #2163 (comment)

Summary by CodeRabbit

  • Refactor
    • Updated internal API type references and imports for improved code consistency.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@ardaguclu: This pull request explicitly references no jira issue.

Details

In response to this:

This PR renames alias of github.com/openshift/api/config/v1 package to configv1 per requested in github.com/openshift/api/config/v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from dgrisonnet and p0lyn0mial May 5, 2026 10:09
@p0lyn0mial

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2026
@openshift-ci

openshift-ci Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026
@coderabbitai

coderabbitai Bot commented May 5, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7b7329a4-b5f0-4f5d-b846-7b80d17d2311

📥 Commits

Reviewing files that changed from the base of the PR and between eae3c72 and 52d4da6.

📒 Files selected for processing (2)
  • pkg/operator/encryption/controllers/key_controller.go
  • pkg/operator/encryption/state/types.go

Walkthrough

Two files update the import alias for github.com/openshift/api/config/v1 from v1 to configv1, with corresponding type reference changes throughout. No logic changes or behavioral modifications.

Changes

Import Alias Standardization

Layer / File(s) Summary
Import Alias Update
pkg/operator/encryption/controllers/key_controller.go, pkg/operator/encryption/state/types.go
Import alias for github.com/openshift/api/config/v1 changed from v1 to configv1 across both files.
Type References
pkg/operator/encryption/controllers/key_controller.go
Method signatures updated: generateKeySecret and getCurrentModeReasonAndEncryptionConfig now reference configv1.APIServerEncryption instead of v1.APIServerEncryption. Early-return error branches in getCurrentModeReasonAndEncryptionConfig construct configv1.APIServerEncryption{} consistently.
Field Type Update
pkg/operator/encryption/state/types.go
KMSConfig.Provider field type changed from *v1.KMSConfig to *configv1.KMSConfig.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: renaming the import alias for the api/config/v1 package to configv1, which is reflected in both modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR does not contain Ginkgo tests. The repository uses standard Go testing framework (testing.T). The check for stable Ginkgo test names is not applicable.
Test Structure And Quality ✅ Passed This PR does not contain Ginkgo test code. The test files use standard Go testing.T package with table-driven tests. The custom check for Ginkgo test quality is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added. The PR only refactors import aliases in production code files. The MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are limited to renaming import aliases for config/v1 API types in non-test files (key_controller.go and types.go).
Topology-Aware Scheduling Compatibility ✅ Passed PR performs pure import alias refactoring (v1→configv1) with no scheduling constraints, affinity rules, nodeSelectors, PodDisruptionBudgets, or topology code changes.
Ote Binary Stdout Contract ✅ Passed PR contains only import alias and type reference refactoring. No main(), init(), or suite setup functions. No stdout writes introduced. No process-level code impacting OTE contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. The changes are a simple refactoring of import aliases in existing production code (renaming configv1 import alias). The check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit de46cb8 into openshift:master May 5, 2026
6 checks passed
@ardaguclu
ardaguclu deleted the rename-configv1-package branch May 5, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants