OCPBUGS-74511: remove RouteExternalCertificate feature gate - #2122
openshift-merge-bot[bot] merged 1 commit into
Conversation
RouteExternalCertificate is now enabled by default. This update is removing the opts used to hold its value, hardcoding the behavior when the value is true. This update needs to be in sync with o/kubernetes and o/openshift-apiserver
openshift-ci-robot
added
jira/valid-reference
|
@jcmoraisjr: This pull request references Jira Issue OCPBUGS-74511, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold needs to be merged after |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/assign |
|
/lgtm |
bertinatto
left a comment
bertinatto
left a comment
There was a problem hiding this comment.
/approve
Is the feature enabled by default since 4.19?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jcmoraisjr, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
@bertinatto: yes. |
|
@bertinatto this change should be immediately followed by changes in both o/kubernetes and o/openshift-apiserver due to the removal of the whole struct. Can you support us in a way we bump and merge all of them quickly, so users trying to bump library-go are not impacted? Otherwise we can change the approach and instead make smaller cleanups on o/kubernetes and o/openshift-apiserver before changing library-go. There is also a new comment here. Any preferable approach? |
It looks like you want to merge the library-go PR first, then bump it in o/k and o/openshift-apiserver. The o/k and o/openshift-apiserver PRs can have:
I recommend you wait for @jacobsee and @jubittajohn to land the kube 1.35 update first. I can approve PRs in o/k and o/library-go. You'll need find an approver for o/openshift-apiserver. |
|
/verified later @mjoseph |
|
@melvinjoseph86: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
verified
|
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-74511, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bertinatto o/openshift-apiserver is still on k 1.34, but I missed the hold tag and it ended up approved and merged. I think I cannot update library-go there due to kube version mismatch, so folks should handle it when bumping kube libs. I'm planning to unhold this one now, immediately followed by bumping its version on o/kubernetes and merging there as well. Sounds good, should we proceed? |
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@jcmoraisjr: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jcmoraisjr: Jira Issue OCPBUGS-74511: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-74511 has not been moved to the MODIFIED state. This PR is marked as verified-later. Jira issue(s) in the title of this PR will require post-merge verification. After testing, it must be manually moved to the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…e-featuregate OCPBUGS-74511: remove RouteExternalCertificate feature gate
|
Fix included in release 5.0.0-0.nightly-2026-05-27-134409 |
|
Fix included in release 5.0.0-0.nightly-2026-08-06-014706 |
8 participants
RouteExternalCertificate featuregate is now enabled by default. This update is removing the opts used to hold its value, hardcoding the behavior when the value is true.
This update needs to be in sync with o/kubernetes and o/openshift-apiserver.