Skip to content

Conversation

@ardaguclu
Copy link
Member

This PR adds KMS as a new mode in encryption controllers to be functioning along side with the other modes. Functionality has been proved to be working #2041.

This PR takes the minimal bits from #2041 (because PoC PR also contains kms plugin communication to obtain the key_id. However, we decided that initially we don't need to track key_id).

Basically, idea is to track the hash of kmsconfig to detect any configuration changes. So that key_controller can create new secret to initiate migration. KMS key secret will not contain any confidential data. It will simply store the hash value of key_id. But for now, we don't access KMS plugin in operator controllers. That means key_id hash value will stay static.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2025
@openshift-ci-robot
Copy link

@ardaguclu: This pull request explicitly references no jira issue.

In response to this:

This PR adds KMS as a new mode in encryption controllers to be functioning along side with the other modes. Functionality has been proved to be working #2041.

This PR takes the minimal bits from #2041 (because PoC PR also contains kms plugin communication to obtain the key_id. However, we decided that initially we don't need to track key_id).

Basically, idea is to track the hash of kmsconfig to detect any configuration changes. So that key_controller can create new secret to initiate migration. KMS key secret will not contain any confidential data. It will simply store the hash value of key_id. But for now, we don't access KMS plugin in operator controllers. That means key_id hash value will stay static.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dgrisonnet and tkashem November 5, 2025 11:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ardaguclu
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Member Author

@ardaguclu
Copy link
Member Author

/hold
until having a green CI

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025
@ardaguclu
Copy link
Member Author

/hold cancel
ready for review

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants