-
Notifications
You must be signed in to change notification settings - Fork 245
NO-JIRA: Introduce KMS encryption mode into encryption controllers #2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@ardaguclu: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ardaguclu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Fake bumps to test CI:
|
|
/hold |
|
/hold cancel |
16d1ed4 to
b18480c
Compare
|
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds KMS as a new mode in encryption controllers to be functioning along side with the other modes. Functionality has been proved to be working #2041.
This PR takes the minimal bits from #2041 (because PoC PR also contains kms plugin communication to obtain the key_id. However, we decided that initially we don't need to track key_id).
Basically, idea is to track the hash of kmsconfig to detect any configuration changes. So that key_controller can create new secret to initiate migration. KMS key secret will not contain any confidential data. It will simply store the hash value of key_id. But for now, we don't access KMS plugin in operator controllers. That means key_id hash value will stay static.